New implementation of code editor by n-riesco · Pull Request #411 · plotly/falcon

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

Closesplotly#412

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

Closesplotly#412

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

Closesplotly#412

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

Closesplotly#412

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

Closesplotly#412

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

Closesplotly#412

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco · 2018-04-06T22:42:43Z

replaced react-codemirror with react-codemirror2
used react-resizable to implement a resize handle
improved CSS styles (CodeEditor, SQLTable and tab list)
TODO: add jest test?

Closes#401
Closes#360
Closes#311
Closes#412

* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

* Uses react-resizable Closesplotly#311

* Removed component CodeEditorField. * Removed dependency react-codemirror.

Closesplotly#412

* Added a margin between the COdeEditor and SQLTable. * Removed margin between the tab headers (Table, Chart, Export) and the corresponding tab panels. * Reduce initial size of CodeEditor from 250px to 140px. * Increase initial size of SQLTable from 200px to 300px. * Updated the styles for SQLTable so that it uses the same color scheme as CodeEditor. * Added a link to toggle the row filters in SQLTable.

n-riesco · 2018-04-10T17:19:33Z

@jackparmer @shannonlal I've updated the PR with a few, small fixes I want to merge before we release Falcon v2.6:

I've made the initial size of the code editor smaller and the table view accordingly larger.
the table view now uses the same color theme as the code editor.
I've changed the way to toggle the row filter (I've a added a link similar to the one used to toggle the code editor).
I've updated ibm_dbto v2.3 (no need for my fork any longer!!!)

Please, let me knwo what you think of the UI changes.

shannonlal

Overall looks really good. My comments are all minor and don't want to block the release. Good job💃

shannonlal · 2018-04-11T02:09:20Z

+ const height = wrapperElement.clientHeight;
+ const width = wrapperElement.clientWidth;
+
+ const minConstraints = [width, 74];


Maybe put 74 as a constant at top with what it represents. const MIN_WIDTH_CONSTRAINTS = 74

shannonlal · 2018-04-11T02:10:00Z

+ static computeAutocompleteTables(props) {
+ const schemaRequest = props.schemaRequest || {};
+
+ if (schemaRequest.status !== 200 || !schemaRequest.content || !schemaRequest.content.rows) {


Should we be moving connection status to a centralized location or atleast have this as a const? Minor thing

No, let's not do that. There is no gain in having STATUS_OK_200 vs 200.

shannonlal · 2018-04-11T02:11:51Z

+ maxConstraints
+ } = this.state;
+
+ const mode = {


If we add other dialects should the be added here? Should we update the NEW_CONNECTION doc?

shannonlal · 2018-04-11T02:12:45Z


 minWidth={740}
- minHeight={200}
+ minHeight={300}


Minor thing. Do these variables belong in const?

No, I wouldn't. My personal criteria for defining a const is:
if the constant is used only once or twice, I only define a const if it documents its meaning; e.g. in minHeight={300}, I don't define a constant, because it's clear that 300 is the minimum height passed to ReactDataGrid.
if the constant is used twice or more times, then I define a constant, because it's easier to update const MY_CONST = 300; in one place than 300 in multiple places.

shannonlal · 2018-04-11T02:14:50Z

Added minor comments that you can review if you have time 💃

* Document how to set the codemirror mode used in the code editor.

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

n-riesco added 5 commits April 10, 2018 12:03

CodeEditor: new implementation
04c3b37
* Implemented CodeEditor using `react-codemirror2`. Closesplotly#401Closesplotly#360

CodeEditor: add resize handle
77ca46a
* Uses react-resizable Closesplotly#311

CodeEditor: removed unused CodeEditorField
5ae9852
* Removed component CodeEditorField. * Removed dependency react-codemirror.

ibmdb: upgrade to v2.3.0
da12e5d
Closesplotly#412

SQLTable: import CSS from component
2942c19

n-riesco force-pushed the editor/use-react-codemirror2 branch from 586f28e to dc37d26Compare April 10, 2018 16:51

n-riesco force-pushed the editor/use-react-codemirror2 branch from dc37d26 to c4f215dCompare April 10, 2018 16:58

SQLTable: update test for toggling row filter
39bbe67

n-riesco mentioned this pull request Apr 10, 2018
SQLTable: make the table view resizable #413
Open

shannonlal reviewed Apr 11, 2018
View reviewed changes

n-riesco added 3 commits April 11, 2018 14:14

doc: update NEW_CONNECTION.md
18d2ed3
* Document how to set the codemirror mode used in the code editor.

CodeEditor: add MIN_CONTRAINST_HEIGHT
93d3307

athena: fix lint warning
8b59abc

n-riesco merged commit 96dfe32 into plotly:masterApr 11, 2018

Uh oh!

Uh oh!

Conversation

n-riesco commented Apr 6, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n-riesco commented Apr 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shannonlal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

n-riescoApr 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shannonlal commented Apr 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

n-riesco commented Apr 6, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n-riesco commented Apr 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shannonlal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

n-riescoApr 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shannonlal commented Apr 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

n-riesco commented Apr 6, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

n-riesco commented Apr 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

n-riesco commented Apr 6, 2018•
edited
Loading

n-riesco commented Apr 10, 2018•
edited
Loading

n-riescoApr 11, 2018•
edited
Loading

n-riesco commented Apr 6, 2018•
edited
Loading

n-riesco commented Apr 10, 2018•
edited
Loading

n-riescoApr 11, 2018•
edited
Loading

n-riesco commented Apr 6, 2018•
edited
Loading

n-riesco commented Apr 10, 2018•
edited
Loading

n-riescoApr 11, 2018•
edited
Loading

n-riesco commented Apr 6, 2018•
edited
Loading

n-riesco commented Apr 10, 2018•
edited
Loading