Uh oh!
There was an error while loading. Please reload this page.
Conversation
TODO:
|
ab3b642 to
bf60eccCompare
shannonlal
left a comment
There was a problem hiding this comment.
Do you need an oracle.LICENSE file as well?
| osx_image: xcode9.0 | ||
| language: node_js | ||
| node_js: "6" | ||
| node_js: "8" |
There was a problem hiding this comment.
Just to confirm. Once this is moved in we will need to use NodeJS 8? Will earlier versions work? Not an issue just want to know.
There was a problem hiding this comment.
The oracle connector won't work in electron and yarn will refuse to install.
If you force yarn to ignore the node version (yarn install --ignore-engines), then Falcon seems to work (I mean everything I tried, except the Oracle connector).
shannonlal
commented
May 20, 2018
Looks good. No major issues. Just had a couple of quick questions for you on but should not block merging this in💃 |
n-riesco
commented
May 21, 2018
We need written permission to use Oracle's logo. For the time being, the icon for Oracle's connector is just text (similar to what I've used for DB2 and CSV). |
I've tested this branch on windows:
The issue I have with the electron app has already been reported: oracle/node-oracledb#917 Running Potential leads:
|
* Implemented connector to Oracle based on node-oracledb. * Implemented a pool of clients to ensure all the request from a connector share the same client. For more details, see `backend/persistent/datastores/pool.js`. * Upgraded to electron@2.0 and node@8, so that: - both node and electron have ABI 57 (for which node-oracledb provides binaries) - unable to use electron@1.8 due to issue resulting in a empty window at some startups * Added Dockerfile and npm scripts to build and launch a container with an Oracle Express database setup for testing. * Ensure connector failures are logged. * Added npm script `test-unit-oracle` for testing. See `CONTRIBUTING.md` for the requirements to run these tests. * Updated documentation in `CONTRIBUTING.md`. Closes#322
* See nodejs/node#16196 for further details about the cause.
* Ensure error response is formatted as {error: message: 'xxxx'}.* Fixed the code parsing a connection error message. * Ensure error message is a string. * Ensure isConnected() and isSaved() returns false when status code is 500. * Added tests. Closes#342
* Use source package from github to prevent the use of prebuilt binaries and force the rebuild of the native module.
n-riesco
commented
May 24, 2018
3c13700 fixes the issue with the windows installer. I've tested both, the linux and the windows installer. @tarzzz, could you test the mac installer here, please? To test the connector for oracle, you'll need to:
|
tarzzz
commented
May 25, 2018
Getting this while trying to connect:
It seems an issue with my Oracle client installation.. !! |
tarzzz
commented
May 25, 2018
Okay, I was able to make it work by correctly installing clients:
Everything looks good to me from testing point of view.. 💃 |
Implemented connector to Oracle based on node-oracledb.
Implemented a pool of clients to ensure all the request from a
connector share the same client. For more details, see
backend/persistent/datastores/pool.js.Upgraded to electron@2.0 and node@8, so that:
binaries)
at some startups
Added Dockerfile and npm scripts to build and launch a container with
an Oracle Express database setup for testing.
Ensure connector failures are logged.
Added npm script
test-unit-oraclefor testing. SeeCONTRIBUTING.mdfor the requirements to run these tests.
Updated documentation in
CONTRIBUTING.md.Closes#322