This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472

Merged
n-riesco merged 34 commits into
plotly:masterfrom
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged

Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom
jakedex:scheduler-fe-state-1

Conversation

@briandennis

@briandennisbriandennis commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.

Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.

mfix22and others added 19 commits June 29, 2018 14:25
@n-riesco

n-riesco commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

Thanks for the PR. I'll review it on Monday.

@shannonlal I guess you may want to have a look at this PR, as this touches the UI.

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js Outdated
@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js Outdated
const Modal = props => {
const EnhancedClass = enhanceWithClickOutside(class extends Component {
handleClickOutside() {
// eslint-disable-next-line

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js Outdated
});

return props.open
? (

@n-riescon-riescoJul 2, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:

returnprops.open ? (expressionIfTrue) : (expressionIfFalse);

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css Outdated
}

/* TODO move this override */
.scheduler .CodeMirror {

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js Outdated
import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies

Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.

Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js Outdated
import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js Outdated
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js Outdated
import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js

@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js Outdated

class IntervalFormatter extends React.Component {
static propTypes = {
value: PropTypes.object

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.

n-riesco
n-riesco reviewed Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js Outdated
};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {

@n-riescon-riescoJul 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:

screenshot from 2018-07-02 17-11-19

@n-riesco

n-riesco commented Jul 2, 2018•
edited by mfix22
Loading

Copy link
Copy Markdown
Contributor

I'm not done writing the review but I've run out of time today. I'll continue tomorrow.

Here are some general code style changes (for new code):

  • new code should use lowercase filenames
  • if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  • use CSS imports; see here for an example.
  • use 4-space indentation

To discuss:

  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.

n-riesco
n-riesco reviewed Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js Outdated
<TabList>
<Tab>Connection</Tab>
<Tab disabled={queryPanelDisabled}>Query</Tab>
<Tab disabled={false}>Schedule</Tab>

@n-riescon-riescoJul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}

n-riesco
n-riesco reviewed Jul 3, 2018
View reviewed changes
Comment threadpackage.json Outdated
"dtrace-provider": "^0.8.6",
"font-awesome": "^4.6.1",
"ibm_db": "^2.3.0",
"match-sorter": "^2.2.3",

@n-riescon-riescoJul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies

n-riesco
n-riesco reviewed Jul 3, 2018
View reviewed changes
Comment threadpackage.json Outdated
"papaparse": "^4.3.7",
"pg": "^4.5.5",
"pg-hstore": "^2.3.2",
"react-click-outside": "^3.0.1",

@n-riescon-riescoJul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies

n-riesco
n-riesco reviewed Jul 3, 2018
View reviewed changes
Comment threadpackage.json Outdated
"pg": "^4.5.5",
"pg-hstore": "^2.3.2",
"react-click-outside": "^3.0.1",
"react-highlight": "^0.12.0",

@n-riescon-riescoJul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies

n-riesco
n-riesco reviewed Jul 3, 2018
View reviewed changes
Comment threadpackage.json Outdated
"sqlite3": "^3.1.13",
"tedious": "^2.1.4"
"tedious": "^2.1.4",
"tohash": "^1.0.2"

@n-riescon-riescoJul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies

n-riesco
n-riesco reviewed Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx Outdated
query: PropTypes.object
};

export const MetaPreviewModal = props => (

@n-riescon-riescoJul 3, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?

If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).

@n-riescon-riesco mentioned this pull request Jul 3, 2018
Open
@n-riesco

n-riesco commented Jul 3, 2018•
edited by mfix22
Loading

Copy link
Copy Markdown
Contributor

TODO

@n-riesco

n-riesco commented Jul 3, 2018

Copy link
Copy Markdown
Contributor

A few more styling issues (see screen capture below):

  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)

peek 2018-07-03 12-43

@nicolaskruchtennicolaskruchten changed the title Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis

briandennis commented Jul 3, 2018

Copy link
Copy Markdown
ContributorAuthor

@n-riesco we've made all the fixes as per your latest feedback

@n-riesco

n-riesco commented Jul 3, 2018

Copy link
Copy Markdown
Contributor

I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.

@briandennis Thanks! It's been a pleasure to read such a clean PR.

@n-riesco
n-riesco merged commit 6233733 into plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472
Merged
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged
Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Conversation
@briandennis
@briandennisbriandennis
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.
Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.
mfix22and others
added 19 commits
June 29, 2018 14:25
@n-riesco
n-riesco
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Thanks for the PR. I'll review it on Monday.
@shannonlal I guess you may want to have a look at this PR, as this touches the UI.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js
Outdated

@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

const Modal = props => {
 const EnhancedClass = enhanceWithClickOutside(class extends Component {
 handleClickOutside() {
 // eslint-disable-next-line
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

 });

 return props.open
 ? (
@n-riescon-riescoJul 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:
returnprops.open ? (expressionIfTrue) : (expressionIfFalse);
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css
Outdated

}

/* TODO move this override */
.scheduler .CodeMirror {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies
Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.
Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


class IntervalFormatter extends React.Component {
 static propTypes = {
 value: PropTypes.object
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:
screenshot from 2018-07-02 17-11-19
@n-riesco
n-riesco
commented
Jul 2, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
I'm not done writing the review but I've run out of time today. I'll continue tomorrow.
Here are some general code style changes (for new code):
  •  new code should use lowercase filenames
  •  if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  •  use CSS imports; see here for an example.
  •  use 4-space indentation
To discuss:
  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js
Outdated

 <TabList>
 <Tab>Connection</Tab>
 <Tab disabled={queryPanelDisabled}>Query</Tab>
 <Tab disabled={false}>Schedule</Tab>
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "dtrace-provider": "^0.8.6",
 "font-awesome": "^4.6.1",
 "ibm_db": "^2.3.0",
 "match-sorter": "^2.2.3",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "papaparse": "^4.3.7",
 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
 "react-highlight": "^0.12.0",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "sqlite3": "^3.1.13",
 "tedious": "^2.1.4"
 "tedious": "^2.1.4",
 "tohash": "^1.0.2"
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx
Outdated

 query: PropTypes.object
};

export const MetaPreviewModal = props => (
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?
If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).
@n-riescon-riesco
mentioned this pull request
Jul 3, 2018

Open

@n-riesco
n-riesco
commented
Jul 3, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
TODO
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
A few more styling issues (see screen capture below):
  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)
peek 2018-07-03 12-43
@nicolaskruchtennicolaskruchten
changed the title
Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis
briandennis
commented
Jul 3, 2018

Copy link


Copy Markdown

ContributorAuthor
@n-riesco we've made all the fixes as per your latest feedback
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.
@briandennis Thanks! It's been a pleasure to read such a clean PR.
@n-riesco
n-riesco
merged commit 6233733
into
plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472
Merged
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged
Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Conversation
@briandennis
@briandennisbriandennis
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.
Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.
mfix22and others
added 19 commits
June 29, 2018 14:25
@n-riesco
n-riesco
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Thanks for the PR. I'll review it on Monday.
@shannonlal I guess you may want to have a look at this PR, as this touches the UI.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js
Outdated

@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

const Modal = props => {
 const EnhancedClass = enhanceWithClickOutside(class extends Component {
 handleClickOutside() {
 // eslint-disable-next-line
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

 });

 return props.open
 ? (
@n-riescon-riescoJul 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:
returnprops.open ? (expressionIfTrue) : (expressionIfFalse);
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css
Outdated

}

/* TODO move this override */
.scheduler .CodeMirror {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies
Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.
Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


class IntervalFormatter extends React.Component {
 static propTypes = {
 value: PropTypes.object
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:
screenshot from 2018-07-02 17-11-19
@n-riesco
n-riesco
commented
Jul 2, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
I'm not done writing the review but I've run out of time today. I'll continue tomorrow.
Here are some general code style changes (for new code):
  •  new code should use lowercase filenames
  •  if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  •  use CSS imports; see here for an example.
  •  use 4-space indentation
To discuss:
  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js
Outdated

 <TabList>
 <Tab>Connection</Tab>
 <Tab disabled={queryPanelDisabled}>Query</Tab>
 <Tab disabled={false}>Schedule</Tab>
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "dtrace-provider": "^0.8.6",
 "font-awesome": "^4.6.1",
 "ibm_db": "^2.3.0",
 "match-sorter": "^2.2.3",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "papaparse": "^4.3.7",
 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
 "react-highlight": "^0.12.0",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "sqlite3": "^3.1.13",
 "tedious": "^2.1.4"
 "tedious": "^2.1.4",
 "tohash": "^1.0.2"
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx
Outdated

 query: PropTypes.object
};

export const MetaPreviewModal = props => (
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?
If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).
@n-riescon-riesco
mentioned this pull request
Jul 3, 2018

Open

@n-riesco
n-riesco
commented
Jul 3, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
TODO
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
A few more styling issues (see screen capture below):
  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)
peek 2018-07-03 12-43
@nicolaskruchtennicolaskruchten
changed the title
Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis
briandennis
commented
Jul 3, 2018

Copy link


Copy Markdown

ContributorAuthor
@n-riesco we've made all the fixes as per your latest feedback
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.
@briandennis Thanks! It's been a pleasure to read such a clean PR.
@n-riesco
n-riesco
merged commit 6233733
into
plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472
Merged
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged
Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Conversation
@briandennis
@briandennisbriandennis
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.
Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.
mfix22and others
added 19 commits
June 29, 2018 14:25
@n-riesco
n-riesco
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Thanks for the PR. I'll review it on Monday.
@shannonlal I guess you may want to have a look at this PR, as this touches the UI.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js
Outdated

@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

const Modal = props => {
 const EnhancedClass = enhanceWithClickOutside(class extends Component {
 handleClickOutside() {
 // eslint-disable-next-line
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

 });

 return props.open
 ? (
@n-riescon-riescoJul 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:
returnprops.open ? (expressionIfTrue) : (expressionIfFalse);
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css
Outdated

}

/* TODO move this override */
.scheduler .CodeMirror {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies
Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.
Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


class IntervalFormatter extends React.Component {
 static propTypes = {
 value: PropTypes.object
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:
screenshot from 2018-07-02 17-11-19
@n-riesco
n-riesco
commented
Jul 2, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
I'm not done writing the review but I've run out of time today. I'll continue tomorrow.
Here are some general code style changes (for new code):
  •  new code should use lowercase filenames
  •  if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  •  use CSS imports; see here for an example.
  •  use 4-space indentation
To discuss:
  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js
Outdated

 <TabList>
 <Tab>Connection</Tab>
 <Tab disabled={queryPanelDisabled}>Query</Tab>
 <Tab disabled={false}>Schedule</Tab>
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "dtrace-provider": "^0.8.6",
 "font-awesome": "^4.6.1",
 "ibm_db": "^2.3.0",
 "match-sorter": "^2.2.3",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "papaparse": "^4.3.7",
 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
 "react-highlight": "^0.12.0",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "sqlite3": "^3.1.13",
 "tedious": "^2.1.4"
 "tedious": "^2.1.4",
 "tohash": "^1.0.2"
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx
Outdated

 query: PropTypes.object
};

export const MetaPreviewModal = props => (
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?
If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).
@n-riescon-riesco
mentioned this pull request
Jul 3, 2018

Open

@n-riesco
n-riesco
commented
Jul 3, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
TODO
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
A few more styling issues (see screen capture below):
  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)
peek 2018-07-03 12-43
@nicolaskruchtennicolaskruchten
changed the title
Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis
briandennis
commented
Jul 3, 2018

Copy link


Copy Markdown

ContributorAuthor
@n-riesco we've made all the fixes as per your latest feedback
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.
@briandennis Thanks! It's been a pleasure to read such a clean PR.
@n-riesco
n-riesco
merged commit 6233733
into
plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472
Merged
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged
Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Conversation
@briandennis
@briandennisbriandennis
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.
Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.
mfix22and others
added 19 commits
June 29, 2018 14:25
@n-riesco
n-riesco
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Thanks for the PR. I'll review it on Monday.
@shannonlal I guess you may want to have a look at this PR, as this touches the UI.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js
Outdated

@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

const Modal = props => {
 const EnhancedClass = enhanceWithClickOutside(class extends Component {
 handleClickOutside() {
 // eslint-disable-next-line
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

 });

 return props.open
 ? (
@n-riescon-riescoJul 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:
returnprops.open ? (expressionIfTrue) : (expressionIfFalse);
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css
Outdated

}

/* TODO move this override */
.scheduler .CodeMirror {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies
Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.
Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


class IntervalFormatter extends React.Component {
 static propTypes = {
 value: PropTypes.object
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:
screenshot from 2018-07-02 17-11-19
@n-riesco
n-riesco
commented
Jul 2, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
I'm not done writing the review but I've run out of time today. I'll continue tomorrow.
Here are some general code style changes (for new code):
  •  new code should use lowercase filenames
  •  if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  •  use CSS imports; see here for an example.
  •  use 4-space indentation
To discuss:
  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js
Outdated

 <TabList>
 <Tab>Connection</Tab>
 <Tab disabled={queryPanelDisabled}>Query</Tab>
 <Tab disabled={false}>Schedule</Tab>
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "dtrace-provider": "^0.8.6",
 "font-awesome": "^4.6.1",
 "ibm_db": "^2.3.0",
 "match-sorter": "^2.2.3",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "papaparse": "^4.3.7",
 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
 "react-highlight": "^0.12.0",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "sqlite3": "^3.1.13",
 "tedious": "^2.1.4"
 "tedious": "^2.1.4",
 "tohash": "^1.0.2"
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx
Outdated

 query: PropTypes.object
};

export const MetaPreviewModal = props => (
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?
If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).
@n-riescon-riesco
mentioned this pull request
Jul 3, 2018

Open

@n-riesco
n-riesco
commented
Jul 3, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
TODO
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
A few more styling issues (see screen capture below):
  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)
peek 2018-07-03 12-43
@nicolaskruchtennicolaskruchten
changed the title
Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis
briandennis
commented
Jul 3, 2018

Copy link


Copy Markdown

ContributorAuthor
@n-riesco we've made all the fixes as per your latest feedback
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.
@briandennis Thanks! It's been a pleasure to read such a clean PR.
@n-riesco
n-riesco
merged commit 6233733
into
plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472
Merged
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged
Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Conversation
@briandennis
@briandennisbriandennis
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.
Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.
mfix22and others
added 19 commits
June 29, 2018 14:25
@n-riesco
n-riesco
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Thanks for the PR. I'll review it on Monday.
@shannonlal I guess you may want to have a look at this PR, as this touches the UI.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js
Outdated

@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

const Modal = props => {
 const EnhancedClass = enhanceWithClickOutside(class extends Component {
 handleClickOutside() {
 // eslint-disable-next-line
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

 });

 return props.open
 ? (
@n-riescon-riescoJul 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:
returnprops.open ? (expressionIfTrue) : (expressionIfFalse);
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css
Outdated

}

/* TODO move this override */
.scheduler .CodeMirror {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies
Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.
Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


class IntervalFormatter extends React.Component {
 static propTypes = {
 value: PropTypes.object
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:
screenshot from 2018-07-02 17-11-19
@n-riesco
n-riesco
commented
Jul 2, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
I'm not done writing the review but I've run out of time today. I'll continue tomorrow.
Here are some general code style changes (for new code):
  •  new code should use lowercase filenames
  •  if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  •  use CSS imports; see here for an example.
  •  use 4-space indentation
To discuss:
  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js
Outdated

 <TabList>
 <Tab>Connection</Tab>
 <Tab disabled={queryPanelDisabled}>Query</Tab>
 <Tab disabled={false}>Schedule</Tab>
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "dtrace-provider": "^0.8.6",
 "font-awesome": "^4.6.1",
 "ibm_db": "^2.3.0",
 "match-sorter": "^2.2.3",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "papaparse": "^4.3.7",
 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
 "react-highlight": "^0.12.0",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "sqlite3": "^3.1.13",
 "tedious": "^2.1.4"
 "tedious": "^2.1.4",
 "tohash": "^1.0.2"
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx
Outdated

 query: PropTypes.object
};

export const MetaPreviewModal = props => (
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?
If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).
@n-riescon-riesco
mentioned this pull request
Jul 3, 2018

Open

@n-riesco
n-riesco
commented
Jul 3, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
TODO
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
A few more styling issues (see screen capture below):
  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)
peek 2018-07-03 12-43
@nicolaskruchtennicolaskruchten
changed the title
Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis
briandennis
commented
Jul 3, 2018

Copy link


Copy Markdown

ContributorAuthor
@n-riesco we've made all the fixes as per your latest feedback
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.
@briandennis Thanks! It's been a pleasure to read such a clean PR.
@n-riesco
n-riesco
merged commit 6233733
into
plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472
Merged
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged
Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Conversation
@briandennis
@briandennisbriandennis
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.
Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.
mfix22and others
added 19 commits
June 29, 2018 14:25
@n-riesco
n-riesco
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Thanks for the PR. I'll review it on Monday.
@shannonlal I guess you may want to have a look at this PR, as this touches the UI.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js
Outdated

@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

const Modal = props => {
 const EnhancedClass = enhanceWithClickOutside(class extends Component {
 handleClickOutside() {
 // eslint-disable-next-line
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

 });

 return props.open
 ? (
@n-riescon-riescoJul 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:
returnprops.open ? (expressionIfTrue) : (expressionIfFalse);
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css
Outdated

}

/* TODO move this override */
.scheduler .CodeMirror {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies
Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.
Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


class IntervalFormatter extends React.Component {
 static propTypes = {
 value: PropTypes.object
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:
screenshot from 2018-07-02 17-11-19
@n-riesco
n-riesco
commented
Jul 2, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
I'm not done writing the review but I've run out of time today. I'll continue tomorrow.
Here are some general code style changes (for new code):
  •  new code should use lowercase filenames
  •  if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  •  use CSS imports; see here for an example.
  •  use 4-space indentation
To discuss:
  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js
Outdated

 <TabList>
 <Tab>Connection</Tab>
 <Tab disabled={queryPanelDisabled}>Query</Tab>
 <Tab disabled={false}>Schedule</Tab>
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "dtrace-provider": "^0.8.6",
 "font-awesome": "^4.6.1",
 "ibm_db": "^2.3.0",
 "match-sorter": "^2.2.3",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "papaparse": "^4.3.7",
 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
 "react-highlight": "^0.12.0",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "sqlite3": "^3.1.13",
 "tedious": "^2.1.4"
 "tedious": "^2.1.4",
 "tohash": "^1.0.2"
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx
Outdated

 query: PropTypes.object
};

export const MetaPreviewModal = props => (
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?
If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).
@n-riescon-riesco
mentioned this pull request
Jul 3, 2018

Open

@n-riesco
n-riesco
commented
Jul 3, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
TODO
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
A few more styling issues (see screen capture below):
  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)
peek 2018-07-03 12-43
@nicolaskruchtennicolaskruchten
changed the title
Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis
briandennis
commented
Jul 3, 2018

Copy link


Copy Markdown

ContributorAuthor
@n-riesco we've made all the fixes as per your latest feedback
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.
@briandennis Thanks! It's been a pleasure to read such a clean PR.
@n-riesco
n-riesco
merged commit 6233733
into
plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Add scheduled query browser - #472
Merged
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Jul 3, 2018
Merged
Add scheduled query browser#472
n-riesco merged 34 commits into
plotly:masterfrom 
jakedex:scheduler-fe-state-1
Conversation
@briandennis
@briandennisbriandennis
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Adds a tab to display the existing scheduled queries in a table. The queries can be searched and when clicked, display the full query string as well as a link to the grid.
Note, this first step only allows query viewing. Creation, deletion, and updating will come in later PRs.
mfix22and others
added 19 commits
June 29, 2018 14:25
@n-riesco
n-riesco
commented
Jun 29, 2018

Copy link


Copy Markdown

Contributor
Thanks for the PR. I'll review it on Monday.
@shannonlal I guess you may want to have a look at this PR, as this touches the UI.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Layout.react.js
Outdated

@@ -0,0 +1,31 @@
import React from 'react';
import PropTypes from 'prop-types';

@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment with a description. Something like "this module contains a collection of helper components for layout purposes" would be enough, unless there is something about the usage of <Row> and <Column> that developers should know.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

const Modal = props => {
 const EnhancedClass = enhanceWithClickOutside(class extends Component {
 handleClickOutside() {
 // eslint-disable-next-line
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove // eslint-disable-next-line
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Modal.react.js
Outdated

 });

 return props.open
 ? (
@n-riescon-riescoJul 2, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format ternary expressions as:
returnprops.open ? (expressionIfTrue) : (expressionIfFalse);
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Preview/code-editor.css
Outdated

}

/* TODO move this override */
.scheduler .CodeMirror {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this change (not needed for this PR)
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import PropTypes from 'prop-types';

import ReactDataGrid from 'react-data-grid';
import ms from 'ms';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add ms to devDependencies
Falcon uses webpack to bundle most of if its dependencies and for this reason most of them are listed as devDependencies.
Only dependencies that webpack is unable to bundle (e.g. node native modules) should be added as dependencies.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import matchSorter from 'match-sorter';
import Highlight from 'react-highlight';

import { Link } from '../Link.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use extensions, i.e. import { Link } from '../Link.react.js';
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import Highlight from 'react-highlight';

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

import { Link } from '../Link.react';
import { Row, Column } from '../Layout.react';
import Modal from '../Modal.react';
import { plotlyUrl } from '../../utils/utils';
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.js
@mfix22
Review Comments#1:
cfc1919
- Add comment
- Remove old code
- Add ms dev
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated


class IntervalFormatter extends React.Component {
 static propTypes = {
 value: PropTypes.object
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly here: either rename value or add description.
n-riesco
n-riesco
reviewed
Jul 2, 2018
View reviewed changes
Comment threadapp/components/Settings/Scheduler.react.js
Outdated

};
const boxStyle = { boxSizing: 'border-box', width: '50%' };

const MetaPreview = props => {
@n-riescon-riescoJul 2, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a styling issue with this component. See:
screenshot from 2018-07-02 17-11-19
@n-riesco
n-riesco
commented
Jul 2, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
I'm not done writing the review but I've run out of time today. I'll continue tomorrow.
Here are some general code style changes (for new code):
  •  new code should use lowercase filenames
  •  if the file contains JSX use the extension .jsx (don't use the extension .react.js)
  •  use CSS imports; see here for an example.
  •  use 4-space indentation
To discuss:
  • backend should provide the UI with the grid's name. At the moment, it's hard for a user to know which grid is updated by a query. The user would have to open a link in the modal preview to know what grid is updated.
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/Settings.react.js
Outdated

 <TabList>
 <Tab>Connection</Tab>
 <Tab disabled={queryPanelDisabled}>Query</Tab>
 <Tab disabled={false}>Schedule</Tab>
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled={false}
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "dtrace-provider": "^0.8.6",
 "font-awesome": "^4.6.1",
 "ibm_db": "^2.3.0",
 "match-sorter": "^2.2.3",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "papaparse": "^4.3.7",
 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "pg": "^4.5.5",
 "pg-hstore": "^2.3.2",
 "react-click-outside": "^3.0.1",
 "react-highlight": "^0.12.0",
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadpackage.json
Outdated

 "sqlite3": "^3.1.13",
 "tedious": "^2.1.4"
 "tedious": "^2.1.4",
 "tohash": "^1.0.2"
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to devDependencies
n-riesco
n-riesco
reviewed
Jul 3, 2018
View reviewed changes
Comment threadapp/components/Settings/scheduler.jsx
Outdated

 query: PropTypes.object
};

export const MetaPreviewModal = props => (
@n-riescon-riescoJul 3, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need for having two components: MetaPreview and MetaPreviewModal?
If possible, I'd like to have a single component with a name that doesn't require to document the purpose of these components (how about SchedulePreview?).
@n-riescon-riesco
mentioned this pull request
Jul 3, 2018

Open

@n-riesco
n-riesco
commented
Jul 3, 2018•

edited by mfix22

Loading

Copy link


Copy Markdown

Contributor
TODO
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
A few more styling issues (see screen capture below):
  • only first row gets highlighted on hover
  • the bottom borders of of the Schedule panel and the Schedules table overlap (add margin?)
peek 2018-07-03 12-43
@nicolaskruchtennicolaskruchten
changed the title
Add scheduled query visualizationAdd scheduled query browserJul 3, 2018
@briandennis
briandennis
commented
Jul 3, 2018

Copy link


Copy Markdown

ContributorAuthor
@n-riesco we've made all the fixes as per your latest feedback
@n-riesco
n-riesco
commented
Jul 3, 2018

Copy link


Copy Markdown

Contributor
I've tested it locally and it looks good. I'll merge it as soon as the tests in CircleCI succeed.
@briandennis Thanks! It's been a pleasure to read such a clean PR.
@n-riesco
n-riesco
merged commit 6233733
into
plotly:masterJul 3, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


2 more reviewers

@n-riescon-riescon-riesco left review comments
@mfix22mfix22mfix22 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@briandennis@n-riesco@mfix22@jakedex