Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.
/orcaPublic archive

Improve runner app - #10

Merged
etpinard merged 3 commits into
masterfrom
improve-runner-app
Aug 28, 2017
Merged

Improve runner app#10
etpinard merged 3 commits into
masterfrom
improve-runner-app

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

No description provided.

- where if 'figure' is present, get-body only parse the figure value
- this is important for mimicking request using path to data/layout
coupled to some other options (e.g. width, height, format)
- to allow runner apps to add `write` step
(e.g. fs.writeFile(outPath, info.body) inside each task,
ensure that the app quits when all async logic is completed.
- after-export-all exit code mimick process exit code
(i.e. 0 for success, 1 for failure)
@etpinard

Copy link
Copy Markdown
ContributorAuthor

Needed for plotly/plotly.js#1972

Merging this now, but feel free to comment.

@etpinard
etpinard merged commit 65deae7 into masterAug 28, 2017
@etpinard
etpinard deleted the improve-runner-app branch August 28, 2017 21:15
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@etpinard