pass command line options to plotly-dash-preview

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃

[antoinerg]

Prior to this PR, the HTML file used by plotly-dash-preview would ALWAYS link to plotly.js on the CDN even when the command-line arguments --plotlyjs is used.

[etpinard]

This stuff here shouldn't happen.

Which npm version are you using?

[antoinerg]

I'm using 6.4.1... Sorry about that. Using 6.5.0 gives me sha512 hashes as expected.

What do you think of the idea of adding "npm": "^6.5.0" in devDependencies?

[antoinerg]

I didn't add npm in devDependencies but used a newer npm version to update package-lock.json in commit 78f3dd8.

Putting npm in devDependencies would make sense to me. That way we would all use the exact same version by running ./node_modules/.bin/npm. We can discuss that later :)

[etpinard]

Hmm. You're suggesting listing npm as a dependency of things to install with npm? That's sounds strange. I've never seen that before. Maybe it's a thing though.

[antoinerg]

You're suggesting listing npm as a dependency of things to install with npm?

Said that way it sounds kinda stupid indeed 😆. We could instead update the CONTRIBUTING.md to state what version of npm is required.

[chriddyp]

We use the engines property in package.json for this in Dash:

• example: https://github.com/plotly/dash-table/blob/03b59fd53cea0c61a42a3124bb126b24d29d51b3/package.json#L91-L94,
• npm docs on engines - https://docs.npmjs.com/files/package.json#engines

[antoinerg]

@etpinard, see @chriddyp's comment above. That's exactly the feature I was looking for: don't let me change package-lock.json if my npm version is wrong! Maybe we should add this here and in plotly.js' repo.

[antoinerg]

Actually, it doesn't really behave the way I was hoping for.

[etpinard]

Let's put that in ./build aka paths.build and use path.join so that your path is compatible on Windows:

const=path.join(paths.build,'plotly-latest.min.js')

[antoinerg]

Brillant! Done in 3e10734

[etpinard]

9111

[antoinerg]

Done in 3e10734!

[etpinard]

Shouldn't we test https also?

[antoinerg]

I think this works since https will match http!

[etpinard]

Ah I see. Could you change the assert msg to

`A script tag refers to an HTTP(S) resource ${url}`

then to avoid any potential confusion.

[antoinerg]

Done in d29367d

[etpinard]

💃