This repository was archived by the owner on Aug 27, 2026. It is now read-only.
/orcaPublic archive

Configure Project for Electron-Builder#52

Merged
JamesCropcho merged 5 commits into from
Feb 16, 2018
Merged

Configure Project for Electron-Builder #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d52ae1c
Remove `build/` (we need to use a tempdir) and add `dist/`
JamesCropcho Feb 7, 2018
4ff2f7a
Fix too-large file size on a test (false negative)
JamesCropcho Feb 7, 2018
1cf1d78
Use a tempdir instead of `build/` because AppImage/Asar doesn't like it
JamesCropcho Feb 7, 2018
d43e52a
Add Electron-Builder and change entry point
JamesCropcho Feb 7, 2018
c10ad12
Resolves @etpinard: "Can we keep build/ for testing stuff. This will …
JamesCropcho Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry
2 changes: 1 addition & 1 deletion bin/plotly-export-server_electron.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down
2 changes: 1 addition & 1 deletion bin/plotly-graph-exporter_electron.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down
0 build/README.md → build/.gitkeep
View file
Open in desktop
File renamed without changes.
22 changes: 20 additions & 2 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
"version": "0.0.1",
"description": "Plotly's image exporting utility",
"license": "MIT",
"main": "src/index.js",
"main": "./bin/plotly-graph-exporter_electron.js",
"bin": {
"plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
"plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
"coverage": "npm run test:unit -- --cov",
"lint": "standard --fix"
},
"build": {
"appId": "com.plotly.image-exporter.graph-exporter",
"electronCompile": false,
"productName": "Plotly Graph Exporter",
"copyright": "Copyright © 2018 ${author}",
"appImage": {
"systemIntegration": "doNotAsk",
"category": "Utility"
},
"win": {
"target": [{
"target": "nsis"
}]},
"mac": {
"target": [{
"target": "default"
}]}

@etpinardetpinardFeb 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),

@JamesCropchoJamesCropchoFeb 7, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.

If you require me to address this further, let me know.

},
"author": "Plotly, Inc.",
"keywords": [
"graphing",
Expand All@@ -26,7 +44,6 @@
],
"dependencies": {
"body": "^5.1.0",
"electron": "^1.7.9",
"fast-isnumeric": "^1.1.1",
"file-type": "^7.2.0",
"get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
},
"devDependencies": {
"devtron": "^1.4.0",
"electron": "^1.7.9",
"electron-debug": "^1.4.0",
"image-size": "^0.6.1",
"sinon": "^3.2.0",
Expand Down
6 changes: 5 additions & 1 deletion src/util/create-index.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down
6 changes: 5 additions & 1 deletion src/util/pdftops.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
*
Expand Down
2 changes: 1 addition & 1 deletion test/common.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down
5 changes: 3 additions & 2 deletions test/integration/plotly-export-server_test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

t.test('piping info write stream', t => {
const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
const outPath = path.join(paths.build, 'dashboard.pdf')
const ws = fs.createWriteStream(outPath)

request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
const ws = fs.createWriteStream(outPath)

request({
Expand Down
3 changes: 2 additions & 1 deletion test/integration/plotly-graph-exporter_test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
'--output-dir', path.join(ROOT_PATH, 'build'),
'--output-dir', path.join(paths.build),
'--verbose'
]

Expand Down
8 changes: 4 additions & 4 deletions test/pretest.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
}
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)
4 changes: 2 additions & 2 deletions test/unit/coerce-component_test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
const compPath = path.join(paths.build, uuid() + '.js')
const comp = {path: compPath}

fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down
2 changes: 1 addition & 1 deletion test/unit/pdftops_test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
if (err) t.fail(err)

const size = fs.statSync(outPath).size
t.ok(size > 1e5, 'min pdf file size')
t.ok(size > 9e4, 'min pdf file size')

@etpinardetpinardFeb 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!

@JamesCropchoJamesCropchoFeb 7, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.

t.ok(size < 4e5, 'max pdf file size')
t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
t.end()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Aug 27, 2026. It is now read-only.

/orcaPublic archive
Configure Project for Electron-Builder#52
 Merged

JamesCropcho
merged 5 commits into

from

Feb 16, 2018
 Merged


Configure Project for Electron-Builder
#52
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
d52ae1c

Remove `build/` (we need to use a tempdir) and add `dist/`


JamesCropcho Feb 7, 2018
4ff2f7a

Fix too-large file size on a test (false negative)


JamesCropcho Feb 7, 2018
1cf1d78

Use a tempdir instead of `build/` because AppImage/Asar doesn't like it


JamesCropcho Feb 7, 2018
d43e52a

Add Electron-Builder and change entry point


JamesCropcho Feb 7, 2018
c10ad12

Resolves @etpinard: "Can we keep build/ for testing stuff. This will …


JamesCropcho Feb 15, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry

2 changes: 1 addition & 1 deletion
bin/plotly-export-server_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

2 changes: 1 addition & 1 deletion
bin/plotly-graph-exporter_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

0
build/README.md → build/.gitkeep

View file


Open in desktop


File renamed without changes.


22 changes: 20 additions & 2 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
 "version": "0.0.1",
 "description": "Plotly's image exporting utility",
 "license": "MIT",
 "main": "src/index.js",
 "main": "./bin/plotly-graph-exporter_electron.js",
 "bin": {
 "plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
 "plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
 "coverage": "npm run test:unit -- --cov",
 "lint": "standard --fix"
 },
 "build": {
 "appId": "com.plotly.image-exporter.graph-exporter",
 "electronCompile": false,
 "productName": "Plotly Graph Exporter",
 "copyright": "Copyright © 2018 ${author}",
 "appImage": {
 "systemIntegration": "doNotAsk",
 "category": "Utility"
 },
 "win": {
 "target": [{
 "target": "nsis"
 }]},
 "mac": {
 "target": [{
 "target": "default"
 }]}
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
 },
 "author": "Plotly, Inc.",
 "keywords": [
 "graphing",
Expand All@@ -26,7 +44,6 @@
 ],
 "dependencies": {
 "body": "^5.1.0",
 "electron": "^1.7.9",
 "fast-isnumeric": "^1.1.1",
 "file-type": "^7.2.0",
 "get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
 },
 "devDependencies": {
 "devtron": "^1.4.0",
 "electron": "^1.7.9",
 "electron-debug": "^1.4.0",
 "image-size": "^0.6.1",
 "sinon": "^3.2.0",
Expand Down

6 changes: 5 additions & 1 deletion
src/util/create-index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down

6 changes: 5 additions & 1 deletion
src/util/pdftops.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
 *
Expand Down

2 changes: 1 addition & 1 deletion
test/common.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down

5 changes: 3 additions & 2 deletions
test/integration/plotly-export-server_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
 })

 t.test('piping info write stream', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
 const outPath = path.join(paths.build, 'dashboard.pdf')
 const ws = fs.createWriteStream(outPath)

 request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
 const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
 const ws = fs.createWriteStream(outPath)

 request({
Expand Down

3 changes: 2 additions & 1 deletion
test/integration/plotly-graph-exporter_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
 '--output-dir', path.join(ROOT_PATH, 'build'),
 '--output-dir', path.join(paths.build),
 '--verbose'
]

Expand Down

8 changes: 4 additions & 4 deletions
test/pretest.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
 }
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)

4 changes: 2 additions & 2 deletions
test/unit/coerce-component_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
 const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
 const compPath = path.join(paths.build, uuid() + '.js')
 const comp = {path: compPath}

 fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down

2 changes: 1 addition & 1 deletion
test/unit/pdftops_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
 if (err) t.fail(err)

 const size = fs.statSync(outPath).size
 t.ok(size > 1e5, 'min pdf file size')
 t.ok(size > 9e4, 'min pdf file size')
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.
 t.ok(size < 4e5, 'max pdf file size')
 t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
 t.end()
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 27, 2026. It is now read-only.

/orcaPublic archive
Configure Project for Electron-Builder#52
 Merged

JamesCropcho
merged 5 commits into

from

Feb 16, 2018
 Merged


Configure Project for Electron-Builder
#52
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
d52ae1c

Remove `build/` (we need to use a tempdir) and add `dist/`


JamesCropcho Feb 7, 2018
4ff2f7a

Fix too-large file size on a test (false negative)


JamesCropcho Feb 7, 2018
1cf1d78

Use a tempdir instead of `build/` because AppImage/Asar doesn't like it


JamesCropcho Feb 7, 2018
d43e52a

Add Electron-Builder and change entry point


JamesCropcho Feb 7, 2018
c10ad12

Resolves @etpinard: "Can we keep build/ for testing stuff. This will …


JamesCropcho Feb 15, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry

2 changes: 1 addition & 1 deletion
bin/plotly-export-server_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

2 changes: 1 addition & 1 deletion
bin/plotly-graph-exporter_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

0
build/README.md → build/.gitkeep

View file


Open in desktop


File renamed without changes.


22 changes: 20 additions & 2 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
 "version": "0.0.1",
 "description": "Plotly's image exporting utility",
 "license": "MIT",
 "main": "src/index.js",
 "main": "./bin/plotly-graph-exporter_electron.js",
 "bin": {
 "plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
 "plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
 "coverage": "npm run test:unit -- --cov",
 "lint": "standard --fix"
 },
 "build": {
 "appId": "com.plotly.image-exporter.graph-exporter",
 "electronCompile": false,
 "productName": "Plotly Graph Exporter",
 "copyright": "Copyright © 2018 ${author}",
 "appImage": {
 "systemIntegration": "doNotAsk",
 "category": "Utility"
 },
 "win": {
 "target": [{
 "target": "nsis"
 }]},
 "mac": {
 "target": [{
 "target": "default"
 }]}
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
 },
 "author": "Plotly, Inc.",
 "keywords": [
 "graphing",
Expand All@@ -26,7 +44,6 @@
 ],
 "dependencies": {
 "body": "^5.1.0",
 "electron": "^1.7.9",
 "fast-isnumeric": "^1.1.1",
 "file-type": "^7.2.0",
 "get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
 },
 "devDependencies": {
 "devtron": "^1.4.0",
 "electron": "^1.7.9",
 "electron-debug": "^1.4.0",
 "image-size": "^0.6.1",
 "sinon": "^3.2.0",
Expand Down

6 changes: 5 additions & 1 deletion
src/util/create-index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down

6 changes: 5 additions & 1 deletion
src/util/pdftops.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
 *
Expand Down

2 changes: 1 addition & 1 deletion
test/common.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down

5 changes: 3 additions & 2 deletions
test/integration/plotly-export-server_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
 })

 t.test('piping info write stream', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
 const outPath = path.join(paths.build, 'dashboard.pdf')
 const ws = fs.createWriteStream(outPath)

 request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
 const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
 const ws = fs.createWriteStream(outPath)

 request({
Expand Down

3 changes: 2 additions & 1 deletion
test/integration/plotly-graph-exporter_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
 '--output-dir', path.join(ROOT_PATH, 'build'),
 '--output-dir', path.join(paths.build),
 '--verbose'
]

Expand Down

8 changes: 4 additions & 4 deletions
test/pretest.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
 }
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)

4 changes: 2 additions & 2 deletions
test/unit/coerce-component_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
 const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
 const compPath = path.join(paths.build, uuid() + '.js')
 const comp = {path: compPath}

 fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down

2 changes: 1 addition & 1 deletion
test/unit/pdftops_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
 if (err) t.fail(err)

 const size = fs.statSync(outPath).size
 t.ok(size > 1e5, 'min pdf file size')
 t.ok(size > 9e4, 'min pdf file size')
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.
 t.ok(size < 4e5, 'max pdf file size')
 t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
 t.end()
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 27, 2026. It is now read-only.

/orcaPublic archive
Configure Project for Electron-Builder#52
 Merged

JamesCropcho
merged 5 commits into

from

Feb 16, 2018
 Merged


Configure Project for Electron-Builder
#52
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
d52ae1c

Remove `build/` (we need to use a tempdir) and add `dist/`


JamesCropcho Feb 7, 2018
4ff2f7a

Fix too-large file size on a test (false negative)


JamesCropcho Feb 7, 2018
1cf1d78

Use a tempdir instead of `build/` because AppImage/Asar doesn't like it


JamesCropcho Feb 7, 2018
d43e52a

Add Electron-Builder and change entry point


JamesCropcho Feb 7, 2018
c10ad12

Resolves @etpinard: "Can we keep build/ for testing stuff. This will …


JamesCropcho Feb 15, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry

2 changes: 1 addition & 1 deletion
bin/plotly-export-server_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

2 changes: 1 addition & 1 deletion
bin/plotly-graph-exporter_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

0
build/README.md → build/.gitkeep

View file


Open in desktop


File renamed without changes.


22 changes: 20 additions & 2 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
 "version": "0.0.1",
 "description": "Plotly's image exporting utility",
 "license": "MIT",
 "main": "src/index.js",
 "main": "./bin/plotly-graph-exporter_electron.js",
 "bin": {
 "plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
 "plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
 "coverage": "npm run test:unit -- --cov",
 "lint": "standard --fix"
 },
 "build": {
 "appId": "com.plotly.image-exporter.graph-exporter",
 "electronCompile": false,
 "productName": "Plotly Graph Exporter",
 "copyright": "Copyright © 2018 ${author}",
 "appImage": {
 "systemIntegration": "doNotAsk",
 "category": "Utility"
 },
 "win": {
 "target": [{
 "target": "nsis"
 }]},
 "mac": {
 "target": [{
 "target": "default"
 }]}
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
 },
 "author": "Plotly, Inc.",
 "keywords": [
 "graphing",
Expand All@@ -26,7 +44,6 @@
 ],
 "dependencies": {
 "body": "^5.1.0",
 "electron": "^1.7.9",
 "fast-isnumeric": "^1.1.1",
 "file-type": "^7.2.0",
 "get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
 },
 "devDependencies": {
 "devtron": "^1.4.0",
 "electron": "^1.7.9",
 "electron-debug": "^1.4.0",
 "image-size": "^0.6.1",
 "sinon": "^3.2.0",
Expand Down

6 changes: 5 additions & 1 deletion
src/util/create-index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down

6 changes: 5 additions & 1 deletion
src/util/pdftops.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
 *
Expand Down

2 changes: 1 addition & 1 deletion
test/common.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down

5 changes: 3 additions & 2 deletions
test/integration/plotly-export-server_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
 })

 t.test('piping info write stream', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
 const outPath = path.join(paths.build, 'dashboard.pdf')
 const ws = fs.createWriteStream(outPath)

 request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
 const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
 const ws = fs.createWriteStream(outPath)

 request({
Expand Down

3 changes: 2 additions & 1 deletion
test/integration/plotly-graph-exporter_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
 '--output-dir', path.join(ROOT_PATH, 'build'),
 '--output-dir', path.join(paths.build),
 '--verbose'
]

Expand Down

8 changes: 4 additions & 4 deletions
test/pretest.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
 }
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)

4 changes: 2 additions & 2 deletions
test/unit/coerce-component_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
 const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
 const compPath = path.join(paths.build, uuid() + '.js')
 const comp = {path: compPath}

 fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down

2 changes: 1 addition & 1 deletion
test/unit/pdftops_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
 if (err) t.fail(err)

 const size = fs.statSync(outPath).size
 t.ok(size > 1e5, 'min pdf file size')
 t.ok(size > 9e4, 'min pdf file size')
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.
 t.ok(size < 4e5, 'max pdf file size')
 t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
 t.end()
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Aug 27, 2026. It is now read-only.

/orcaPublic archive
Configure Project for Electron-Builder#52
 Merged

JamesCropcho
merged 5 commits into

from

Feb 16, 2018
 Merged


Configure Project for Electron-Builder
#52
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
d52ae1c

Remove `build/` (we need to use a tempdir) and add `dist/`


JamesCropcho Feb 7, 2018
4ff2f7a

Fix too-large file size on a test (false negative)


JamesCropcho Feb 7, 2018
1cf1d78

Use a tempdir instead of `build/` because AppImage/Asar doesn't like it


JamesCropcho Feb 7, 2018
d43e52a

Add Electron-Builder and change entry point


JamesCropcho Feb 7, 2018
c10ad12

Resolves @etpinard: "Can we keep build/ for testing stuff. This will …


JamesCropcho Feb 15, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry

2 changes: 1 addition & 1 deletion
bin/plotly-export-server_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

2 changes: 1 addition & 1 deletion
bin/plotly-graph-exporter_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

0
build/README.md → build/.gitkeep

View file


Open in desktop


File renamed without changes.


22 changes: 20 additions & 2 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
 "version": "0.0.1",
 "description": "Plotly's image exporting utility",
 "license": "MIT",
 "main": "src/index.js",
 "main": "./bin/plotly-graph-exporter_electron.js",
 "bin": {
 "plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
 "plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
 "coverage": "npm run test:unit -- --cov",
 "lint": "standard --fix"
 },
 "build": {
 "appId": "com.plotly.image-exporter.graph-exporter",
 "electronCompile": false,
 "productName": "Plotly Graph Exporter",
 "copyright": "Copyright © 2018 ${author}",
 "appImage": {
 "systemIntegration": "doNotAsk",
 "category": "Utility"
 },
 "win": {
 "target": [{
 "target": "nsis"
 }]},
 "mac": {
 "target": [{
 "target": "default"
 }]}
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
 },
 "author": "Plotly, Inc.",
 "keywords": [
 "graphing",
Expand All@@ -26,7 +44,6 @@
 ],
 "dependencies": {
 "body": "^5.1.0",
 "electron": "^1.7.9",
 "fast-isnumeric": "^1.1.1",
 "file-type": "^7.2.0",
 "get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
 },
 "devDependencies": {
 "devtron": "^1.4.0",
 "electron": "^1.7.9",
 "electron-debug": "^1.4.0",
 "image-size": "^0.6.1",
 "sinon": "^3.2.0",
Expand Down

6 changes: 5 additions & 1 deletion
src/util/create-index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down

6 changes: 5 additions & 1 deletion
src/util/pdftops.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
 *
Expand Down

2 changes: 1 addition & 1 deletion
test/common.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down

5 changes: 3 additions & 2 deletions
test/integration/plotly-export-server_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
 })

 t.test('piping info write stream', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
 const outPath = path.join(paths.build, 'dashboard.pdf')
 const ws = fs.createWriteStream(outPath)

 request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
 const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
 const ws = fs.createWriteStream(outPath)

 request({
Expand Down

3 changes: 2 additions & 1 deletion
test/integration/plotly-graph-exporter_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
 '--output-dir', path.join(ROOT_PATH, 'build'),
 '--output-dir', path.join(paths.build),
 '--verbose'
]

Expand Down

8 changes: 4 additions & 4 deletions
test/pretest.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
 }
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)

4 changes: 2 additions & 2 deletions
test/unit/coerce-component_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
 const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
 const compPath = path.join(paths.build, uuid() + '.js')
 const comp = {path: compPath}

 fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down

2 changes: 1 addition & 1 deletion
test/unit/pdftops_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
 if (err) t.fail(err)

 const size = fs.statSync(outPath).size
 t.ok(size > 1e5, 'min pdf file size')
 t.ok(size > 9e4, 'min pdf file size')
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.
 t.ok(size < 4e5, 'max pdf file size')
 t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
 t.end()
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 27, 2026. It is now read-only.

/orcaPublic archive
Configure Project for Electron-Builder#52
 Merged

JamesCropcho
merged 5 commits into

from

Feb 16, 2018
 Merged


Configure Project for Electron-Builder
#52
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
d52ae1c

Remove `build/` (we need to use a tempdir) and add `dist/`


JamesCropcho Feb 7, 2018
4ff2f7a

Fix too-large file size on a test (false negative)


JamesCropcho Feb 7, 2018
1cf1d78

Use a tempdir instead of `build/` because AppImage/Asar doesn't like it


JamesCropcho Feb 7, 2018
d43e52a

Add Electron-Builder and change entry point


JamesCropcho Feb 7, 2018
c10ad12

Resolves @etpinard: "Can we keep build/ for testing stuff. This will …


JamesCropcho Feb 15, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry

2 changes: 1 addition & 1 deletion
bin/plotly-export-server_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

2 changes: 1 addition & 1 deletion
bin/plotly-graph-exporter_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

0
build/README.md → build/.gitkeep

View file


Open in desktop


File renamed without changes.


22 changes: 20 additions & 2 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
 "version": "0.0.1",
 "description": "Plotly's image exporting utility",
 "license": "MIT",
 "main": "src/index.js",
 "main": "./bin/plotly-graph-exporter_electron.js",
 "bin": {
 "plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
 "plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
 "coverage": "npm run test:unit -- --cov",
 "lint": "standard --fix"
 },
 "build": {
 "appId": "com.plotly.image-exporter.graph-exporter",
 "electronCompile": false,
 "productName": "Plotly Graph Exporter",
 "copyright": "Copyright © 2018 ${author}",
 "appImage": {
 "systemIntegration": "doNotAsk",
 "category": "Utility"
 },
 "win": {
 "target": [{
 "target": "nsis"
 }]},
 "mac": {
 "target": [{
 "target": "default"
 }]}
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
 },
 "author": "Plotly, Inc.",
 "keywords": [
 "graphing",
Expand All@@ -26,7 +44,6 @@
 ],
 "dependencies": {
 "body": "^5.1.0",
 "electron": "^1.7.9",
 "fast-isnumeric": "^1.1.1",
 "file-type": "^7.2.0",
 "get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
 },
 "devDependencies": {
 "devtron": "^1.4.0",
 "electron": "^1.7.9",
 "electron-debug": "^1.4.0",
 "image-size": "^0.6.1",
 "sinon": "^3.2.0",
Expand Down

6 changes: 5 additions & 1 deletion
src/util/create-index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down

6 changes: 5 additions & 1 deletion
src/util/pdftops.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
 *
Expand Down

2 changes: 1 addition & 1 deletion
test/common.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down

5 changes: 3 additions & 2 deletions
test/integration/plotly-export-server_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
 })

 t.test('piping info write stream', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
 const outPath = path.join(paths.build, 'dashboard.pdf')
 const ws = fs.createWriteStream(outPath)

 request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
 const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
 const ws = fs.createWriteStream(outPath)

 request({
Expand Down

3 changes: 2 additions & 1 deletion
test/integration/plotly-graph-exporter_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
 '--output-dir', path.join(ROOT_PATH, 'build'),
 '--output-dir', path.join(paths.build),
 '--verbose'
]

Expand Down

8 changes: 4 additions & 4 deletions
test/pretest.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
 }
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)

4 changes: 2 additions & 2 deletions
test/unit/coerce-component_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
 const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
 const compPath = path.join(paths.build, uuid() + '.js')
 const comp = {path: compPath}

 fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down

2 changes: 1 addition & 1 deletion
test/unit/pdftops_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
 if (err) t.fail(err)

 const size = fs.statSync(outPath).size
 t.ok(size > 1e5, 'min pdf file size')
 t.ok(size > 9e4, 'min pdf file size')
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.
 t.ok(size < 4e5, 'max pdf file size')
 t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
 t.end()
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Aug 27, 2026. It is now read-only.

/orcaPublic archive
Configure Project for Electron-Builder#52
 Merged

JamesCropcho
merged 5 commits into

from

Feb 16, 2018
 Merged


Configure Project for Electron-Builder
#52
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
d52ae1c

Remove `build/` (we need to use a tempdir) and add `dist/`


JamesCropcho Feb 7, 2018
4ff2f7a

Fix too-large file size on a test (false negative)


JamesCropcho Feb 7, 2018
1cf1d78

Use a tempdir instead of `build/` because AppImage/Asar doesn't like it


JamesCropcho Feb 7, 2018
d43e52a

Add Electron-Builder and change entry point


JamesCropcho Feb 7, 2018
c10ad12

Resolves @etpinard: "Can we keep build/ for testing stuff. This will …


JamesCropcho Feb 15, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry

2 changes: 1 addition & 1 deletion
bin/plotly-export-server_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

2 changes: 1 addition & 1 deletion
bin/plotly-graph-exporter_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

0
build/README.md → build/.gitkeep

View file


Open in desktop


File renamed without changes.


22 changes: 20 additions & 2 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
 "version": "0.0.1",
 "description": "Plotly's image exporting utility",
 "license": "MIT",
 "main": "src/index.js",
 "main": "./bin/plotly-graph-exporter_electron.js",
 "bin": {
 "plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
 "plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
 "coverage": "npm run test:unit -- --cov",
 "lint": "standard --fix"
 },
 "build": {
 "appId": "com.plotly.image-exporter.graph-exporter",
 "electronCompile": false,
 "productName": "Plotly Graph Exporter",
 "copyright": "Copyright © 2018 ${author}",
 "appImage": {
 "systemIntegration": "doNotAsk",
 "category": "Utility"
 },
 "win": {
 "target": [{
 "target": "nsis"
 }]},
 "mac": {
 "target": [{
 "target": "default"
 }]}
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
 },
 "author": "Plotly, Inc.",
 "keywords": [
 "graphing",
Expand All@@ -26,7 +44,6 @@
 ],
 "dependencies": {
 "body": "^5.1.0",
 "electron": "^1.7.9",
 "fast-isnumeric": "^1.1.1",
 "file-type": "^7.2.0",
 "get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
 },
 "devDependencies": {
 "devtron": "^1.4.0",
 "electron": "^1.7.9",
 "electron-debug": "^1.4.0",
 "image-size": "^0.6.1",
 "sinon": "^3.2.0",
Expand Down

6 changes: 5 additions & 1 deletion
src/util/create-index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down

6 changes: 5 additions & 1 deletion
src/util/pdftops.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
 *
Expand Down

2 changes: 1 addition & 1 deletion
test/common.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down

5 changes: 3 additions & 2 deletions
test/integration/plotly-export-server_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
 })

 t.test('piping info write stream', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
 const outPath = path.join(paths.build, 'dashboard.pdf')
 const ws = fs.createWriteStream(outPath)

 request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
 const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
 const ws = fs.createWriteStream(outPath)

 request({
Expand Down

3 changes: 2 additions & 1 deletion
test/integration/plotly-graph-exporter_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
 '--output-dir', path.join(ROOT_PATH, 'build'),
 '--output-dir', path.join(paths.build),
 '--verbose'
]

Expand Down

8 changes: 4 additions & 4 deletions
test/pretest.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
 }
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)

4 changes: 2 additions & 2 deletions
test/unit/coerce-component_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
 const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
 const compPath = path.join(paths.build, uuid() + '.js')
 const comp = {path: compPath}

 fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down

2 changes: 1 addition & 1 deletion
test/unit/pdftops_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
 if (err) t.fail(err)

 const size = fs.statSync(outPath).size
 t.ok(size > 1e5, 'min pdf file size')
 t.ok(size > 9e4, 'min pdf file size')
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.
 t.ok(size < 4e5, 'max pdf file size')
 t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
 t.end()
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Aug 27, 2026. It is now read-only.

/orcaPublic archive
Configure Project for Electron-Builder#52
 Merged

JamesCropcho
merged 5 commits into

from

Feb 16, 2018
 Merged


Configure Project for Electron-Builder
#52
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
d52ae1c

Remove `build/` (we need to use a tempdir) and add `dist/`


JamesCropcho Feb 7, 2018
4ff2f7a

Fix too-large file size on a test (false negative)


JamesCropcho Feb 7, 2018
1cf1d78

Use a tempdir instead of `build/` because AppImage/Asar doesn't like it


JamesCropcho Feb 7, 2018
d43e52a

Add Electron-Builder and change entry point


JamesCropcho Feb 7, 2018
c10ad12

Resolves @etpinard: "Can we keep build/ for testing stuff. This will …


JamesCropcho Feb 15, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
.gitignore

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ npm-debug.log*
coverage
.nyc_output

build/*
!build/README.md
/build
dist/

deployment/*.retry

2 changes: 1 addition & 1 deletion
bin/plotly-export-server_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getServerArgs, getServerHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

2 changes: 1 addition & 1 deletion
bin/plotly-graph-exporter_electron.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
const plotlyExporter = require('../')
const plotlyExporter = require('../src/index.js')
const { getExporterArgs, getExporterHelpMsg } = require('./args')
const pkg = require('../package.json')

Expand Down

0
build/README.md → build/.gitkeep

View file


Open in desktop


File renamed without changes.


22 changes: 20 additions & 2 deletions
package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
 "version": "0.0.1",
 "description": "Plotly's image exporting utility",
 "license": "MIT",
 "main": "src/index.js",
 "main": "./bin/plotly-graph-exporter_electron.js",
 "bin": {
 "plotly-graph-exporter": "./bin/plotly-graph-exporter.js",
 "plotly-export-server": "./bin/plotly-export-server.js"
Expand All@@ -17,6 +17,24 @@
 "coverage": "npm run test:unit -- --cov",
 "lint": "standard --fix"
 },
 "build": {
 "appId": "com.plotly.image-exporter.graph-exporter",
 "electronCompile": false,
 "productName": "Plotly Graph Exporter",
 "copyright": "Copyright © 2018 ${author}",
 "appImage": {
 "systemIntegration": "doNotAsk",
 "category": "Utility"
 },
 "win": {
 "target": [{
 "target": "nsis"
 }]},
 "mac": {
 "target": [{
 "target": "default"
 }]}
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding Linux deb target so that I can test it on my laptop? (Sorry for the inconvenience if any),
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Ubuntu as the main OS on my laptop, which is a Debian distribution. AppImage is the default format for this build target. If one runs electron-builder . or similar, one would get an AppImage which one can execute on Debian.
If you require me to address this further, let me know.
 },
 "author": "Plotly, Inc.",
 "keywords": [
 "graphing",
Expand All@@ -26,7 +44,6 @@
 ],
 "dependencies": {
 "body": "^5.1.0",
 "electron": "^1.7.9",
 "fast-isnumeric": "^1.1.1",
 "file-type": "^7.2.0",
 "get-stdin": "^5.0.1",
Expand All@@ -45,6 +62,7 @@
 },
 "devDependencies": {
 "devtron": "^1.4.0",
 "electron": "^1.7.9",
 "electron-debug": "^1.4.0",
 "image-size": "^0.6.1",
 "sinon": "^3.2.0",
Expand Down

6 changes: 5 additions & 1 deletion
src/util/create-index.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,9 +2,13 @@ const fs = require('fs')
const path = require('path')
const uuid = require('uuid/v4')
const isNonEmptyString = require('./is-non-empty-string')
const os = require('os')

const COMPONENT_GLOBAL = 'PlotlyExporterComponent'
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}
const PATH_TO_INIT_RENDERERS = path.join(__dirname, 'init-renderers.js')

/** Create HTML index file
Expand Down

6 changes: 5 additions & 1 deletion
src/util/pdftops.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,12 @@ const childProcess = require('child_process')
const parallel = require('run-parallel')
const series = require('run-series')
const uuid = require('uuid/v4')
const os = require('os')

const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')
const PATH_TO_BUILD = path.join(os.tmpdir(), 'plotly-graph-exporter-build')
try {
 fs.mkdirSync(PATH_TO_BUILD)
} catch (e) {}

/** Node wrapper for pdftops
 *
Expand Down

2 changes: 1 addition & 1 deletion
test/common.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ const urls = {}
const mocks = {}

paths.root = path.join(__dirname, '..')
paths.build = path.join(paths.root, 'build')
paths.build = path.join(path.join(paths.root, 'build'))
paths.bin = path.join(paths.root, 'bin')
paths.readme = path.join(paths.root, 'README.md')
paths.pkg = path.join(paths.root, 'package.json')
Expand Down

5 changes: 3 additions & 2 deletions
test/integration/plotly-export-server_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ const fs = require('fs')
const request = require('request')
const readChunk = require('read-chunk')
const fileType = require('file-type')
const { paths } = require('../common')

const PORT = 9109
const SERVER_URL = `http://localhost:${PORT}`
Expand DownExpand Up@@ -110,7 +111,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
 })

 t.test('piping info write stream', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard.pdf')
 const outPath = path.join(paths.build, 'dashboard.pdf')
 const ws = fs.createWriteStream(outPath)

 request({
Expand DownExpand Up@@ -139,7 +140,7 @@ tap.test('should work for *plotly-dashboard* component', {timeout: 1e5}, t => {
})

tap.test('should work for *plotly-dashboard-thumbnail* component', t => {
 const outPath = path.join(ROOT_PATH, 'build', 'dashboard-thumbnail.png')
 const outPath = path.join(paths.build, 'dashboard-thumbnail.png')
 const ws = fs.createWriteStream(outPath)

 request({
Expand Down

3 changes: 2 additions & 1 deletion
test/integration/plotly-graph-exporter_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,11 +2,12 @@ const tap = require('tap')
const { spawn } = require('child_process')
const path = require('path')
const pkg = require('../../package.json')
const { paths } = require('../common')

const ROOT_PATH = path.join(__dirname, '..', '..')
const BIN = path.join(ROOT_PATH, 'bin', 'plotly-graph-exporter.js')
const BASE_ARGS = [
 '--output-dir', path.join(ROOT_PATH, 'build'),
 '--output-dir', path.join(paths.build),
 '--verbose'
]

Expand Down

8 changes: 4 additions & 4 deletions
test/pretest.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,8 +10,8 @@ const mock = JSON.stringify({
 }
})

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d build -o test-mock`)
console.log('build/test-mock.svg created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f svg -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.svg created`)

execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d build -o test-mock`)
console.log('build/test-mock.pdf created')
execSync(`${paths.bin}/plotly-graph-exporter.js '${mock}' -f pdf -d ${paths.build} -o test-mock`)
console.log(`${paths.build}/test-mock.pdf created`)

4 changes: 2 additions & 2 deletions
test/unit/coerce-component_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,12 +3,12 @@ const sinon = require('sinon')
const path = require('path')
const fs = require('fs')
const uuid = require('uuid/v4')
const { paths } = require('../common')

const coerceComponent = require('../../src/util/coerce-component')
const PATH_TO_BUILD = path.join(__dirname, '..', '..', 'build')

const testMockComponentModule = (t, compModuleContent, cb) => {
 const compPath = path.join(PATH_TO_BUILD, uuid() + '.js')
 const compPath = path.join(paths.build, uuid() + '.js')
 const comp = {path: compPath}

 fs.writeFile(compPath, compModuleContent, (err) => {
Expand Down

2 changes: 1 addition & 1 deletion
test/unit/pdftops_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ tap.test('pdftops.pdf2eps', t => {
 if (err) t.fail(err)

 const size = fs.statSync(outPath).size
 t.ok(size > 1e5, 'min pdf file size')
 t.ok(size > 9e4, 'min pdf file size')
@etpinardetpinardFeb 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #48 I presume? Nice!
@JamesCropchoJamesCropchoFeb 7, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir.
 t.ok(size < 4e5, 'max pdf file size')
 t.ok(fileType(readChunk.sync(outPath, 0, 4100)).mime === 'application/postscript', 'postscript content')
 t.end()
Expand Down