Skip to content

upgrade plotly.js - #1450

Closed
cpsievert wants to merge 14 commits into
masterfrom
v1.43
Closed

upgrade plotly.js#1450
cpsievert wants to merge 14 commits into
masterfrom
v1.43

Conversation

@cpsievert

@cpsievertcpsievert commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

TODO

These plotly.js release notes will require some R changes:

  • title attributes linked to strings are now deprecated. Please use title.text instead to fill in your title text [#3276]
  • title* attributes are now deprecated. They moved to title.*. For example, colorbar.titleside is now colorbar.title.side [#3276]

FWIW, I'm pretty sure layout.title, layout.titlefont, layout[axisid].title, layout[axisid].titlefont, marker.colorbar.title, marker.colorbar.titlefont, marker.colorbar.titleside, and carpet-specific attributes are the only ones effected.

  • It looks like these attributes still work, but be good form to identify these cases on the R side and throw an information deprecation message/warning.
  • Update any 'internal' logic using these attributes to use the new nested structure.
  • Would also be a good time to have ggplotly() leverage the new layout.title and layout[axisid].title placement attributes

@cpsievertcpsievert changed the title upgrade to plotly.js v1.43upgrade plotly.jsFeb 11, 2019
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

Closing in favor of #1506

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@cpsievert