Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Version 1.0 - #226

Merged
cpsievert merged 235 commits into
masterfrom
carson-dsl
Aug 1, 2015
Merged

Version 1.0#226
cpsievert merged 235 commits into
masterfrom
carson-dsl

Conversation

@cpsievert

Copy link
Copy Markdown
Collaborator

This is a major revision of the R API which includes a new declarative DSL. See here for an overview of that system.

I decided to branch off from #217 since some of those comments are now obsolete. Here is a more succinct list of other noteworthy technical changes:

This isn’t quite ready for a serious review since the new visual testing table isn't ready.

It would be huge help to me if others could help produce examples for help pages and report any problems/issues (I'm sure there are certain use cases I haven't accounted for).

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73382471

On TravisCI, commit 66397c4 was successfully merged with 6ff8831 (master) to create 5d64a3d. A visual testing table comparing 6ff8831 with 5d64a3d can be found here ->

http://cpsievert.github.io/plotly-test-table/R/5d64a3d/

Detected 0 differences

@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73449326

On TravisCI, commit 53bcd01 was successfully merged with 6ff8831 (master) to create 60de0d4. A visual testing table comparing 6ff8831 with 60de0d4 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/60de0d4/

Detected 0 differences

@cpsievertcpsievert mentioned this pull request Jul 31, 2015
cpsievert added a commit that referenced this pull request Aug 1, 2015
@cpsievert
cpsievert merged commit b610dcf into masterAug 1, 2015
@cpsievert

Copy link
Copy Markdown
CollaboratorAuthor

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73651845

On TravisCI, commit 27c7ac4 was successfully merged with 6ff8831 (master) to create d3e31fe. A visual testing table comparing 6ff8831 with d3e31fe can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe/

Detected 149 differences ->

http://cpsievert.github.io/plotly-test-table/R/d3e31fe//abline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area-fillcolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//area
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-colour-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-color-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-aes-fill-guides-fill-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-black-outline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-category-names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-factor-category
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-nocolor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-position-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//bar-stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//contour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-coord-fixed-ratio
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-fonts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-linear-axes
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-coord
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-log2-scale
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-no-x-title
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-axes-scale_y_log10
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-err4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color-error
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-dodge-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-diff
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-narrow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-bar-error-wide
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-bar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-basic-horizontal-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-dashed-red-line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-line-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//cookbook-lines-scatter-hline-vline-stat
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-class-Date
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-irregular-time-series
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//date-strings
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density2d
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-histogram
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//density-simple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar-horizontal
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//errorbar
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_grid_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_x
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//facet_wrap_free_y
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//heatmap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-counts
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-Date-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-dates
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density-binwidth
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-density
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-dodge
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-facets
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor-identity
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-fixed-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-POSIXt-bins
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//histogram-vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-factor
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//hline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-angles
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ggtitle
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-scale_x_continuous_name
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//labels-ylab
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-2traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-3traces-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-breaks
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-position-none
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//legend-iris-trace-showlegend-FALSE
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//linetype-types
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//names
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colored-groups-stay-together
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-colors
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-lines-diff-from-paths
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//path-line-symbols
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-aes-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-linetype
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-color-fill-aes-size
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygons-canada-borders
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//polygon-star-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black4
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-black
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//rect-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-alpha
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-fill
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ribbon-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-color
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-full-range
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-hollow
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-jitter
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-loess
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-overlap
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-scale-color-hue
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape-manual
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-shape
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//scatterplots-smooth-lm-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//segment
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-is-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//size-not-a-vector
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-basic
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-colour
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-facet
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-fill2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-group
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//smooth-se-false
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//stack
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_line
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//step-gg.linear-geom_path
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-background
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-dashed-grid-lines
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-1
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-panel-border-2
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-and-grids
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-ticks-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//theme-zeroline-default
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-ticks-labels
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ticks-hide-y-keep-grid
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline-multiple
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//vline
http://cpsievert.github.io/plotly-test-table/R/d3e31fe//ylim-one-trace

@cpsievert
cpsievert deleted the carson-dsl branch August 1, 2015 14:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed re-design

3 participants

@cpsievert@chriddyp@theengineear