Uh oh!
There was an error while loading. Please reload this page.
Fix dendrogram - #1063
Merged
Merged
Conversation
- no need to call getSubplots twice, grab subplot ids from _plots hash for speed.
- which is a more precise description than data, after than defaults step.
| // look for subplots in the data | ||
| var data = gd.data || []; | ||
| var data = gd._fullData || gd.data || []; |
Collaborator
There was a problem hiding this comment.
nonblocking, but do we even need gd.data here then?
Collaborator
There was a problem hiding this comment.
ah good call, forgot streambed might still be using this 👍
alexcjohnson
approved these changes
Oct 24, 2016
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
Nice and easy 💃 !
Thanks for including the dendrogram test, definitely something we should have,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #946 broke a few funky layout configurations.
Take for example this dendrogram: https://plot.ly/~talgalili/23
This fix is simple. Make sure that all
Axes.gertSuplots, including the (new)linkSubplots, usefullDataif present on-par with what the subplot-layer-creation routine expects.