') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [EXPERIMENTAL] Run standard --fix by rreusser · Pull Request #1371 · plotly/plotly.js · GitHub
Skip to content

[EXPERIMENTAL] Run standard --fix - #1371

Closed
rreusser wants to merge 1 commit into
masterfrom
standard
Closed

[EXPERIMENTAL] Run standard --fix#1371
rreusser wants to merge 1 commit into
masterfrom
standard

Conversation

@rreusser

@rreusserrreusser commented Feb 10, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

This is a test PR, mainly to get the ball rolling and see what would happen if we simply applied standard formatting. There are lots of rules that will require manual rewriting.

In particular, the vast majority look like

convert.js:219:72: ':' should be placed at the beginning of the line.
index.js:34:3: Split initialized 'var' declarations into multiple statements.

It's probably a couple hour pass to go through and fix those, then a bit more work to figure out maybe a few more subtle issues.

See: #950 ping @etpinard

@etpinard

etpinard commented Feb 10, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Hey, at least all the ; are gone!

@rreusser

rreusser commented Feb 10, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Of note:eslint is the only phase of the tests this PR broke (which is not a foregone conclusion considering 408 files +41,098 / −42,357)

@rreusser

rreusser commented Feb 13, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Common sentiment overheard: "OMG eslint is just horrible to have to run all the time. prettier solves this whole problem in a way that makes fundamentally so much more sense. So over eslint." Paraphrasing, of course. People seem very excited about dumping eslint for prettier though. In summary, eslint 'fixes' your code by tweaking it. Prettier parses the AST, dumps the original code, and reprints it with perfectly consistent and standardized formatting.

If I understand then, there aren't rules to violate. You write code. It reinterprets it and applies its own formatting. Seems nice.

@rreusserrreusser mentioned this pull request Feb 13, 2017
Closed
@rreusser

rreusser commented Feb 13, 2017

Copy link
Copy Markdown
ContributorAuthor

Holding off until some large PRs have been merged.

@rreusser

rreusser commented Feb 14, 2017

Copy link
Copy Markdown
ContributorAuthor

FWIW:

screen shot 2017-02-14 at 14 23 25

@rreusserrreusser mentioned this pull request Feb 24, 2017
Merged
@rreusserrreusser mentioned this pull request Apr 26, 2017
Merged
@rreusser

rreusser commented May 1, 2017

Copy link
Copy Markdown
ContributorAuthor

Closing for now. Can revisit if changing the linting seems like the right move.

@rreusserrreusser closed this May 1, 2017
@etpinard
etpinard deleted the standard branch May 16, 2017 19:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rreusser@etpinard