More scattergl symbols

[destradafilm]

Added 49 more symbols to get as close to the 'scatter' plot symbol list to include :

circle
circle-open
square
square-open
diamond
diamond-open
cross
x
triangle-up
triangle-up-open
triangle-down
triangle-down-open
triangle-left
triangle-left-open
triangle-right
triangle-right-open
triangle-ne
triangle-ne-open
triangle-nw
triangle-nw-open
triangle-se
triangle-se-open
triangle-sw
triangle-sw-open
pentagon
pentagon-open
hexagon
hexagon-open
hexagon2
star
star-open
hexagram
diamond-tall
diamond-tall-open
hourglass
hourglass-open
bowtie
bowtie-open
circle-cross
circle-x
square-cross
square-x
cross-thin
asterisk

previous list:

updated list:

[etpinard]

Thanks a lot!

We should make these on-par with the SVG symbol list or at the very least we shouldn't add scattergl-only symbols.

[etpinard]

... and by the way please we don't need those devtools/ modifications as part of this PR.

[destradafilm]

@etpinard Sounds good, I reverted the devtools folder back to master.

I attempted to find all the unicode symbols that I could to match the SVG symbol list, but couldn't find all of them, so this is the best I could do.

I'm wondering, would it make sense to render the symbols on the scattergl from the same SVGs? Or is there a reason it's using Unicode symbols?

[destradafilm]

And, I actually counted wrong, there's 35 more symbols so a total of 43

[etpinard]

@destradafilm try running npm run lint-fix

[etpinard]

I attempted to find all the unicode symbols that I could to match the SVG symbol list, but couldn't find all of them, so this is the best I could do.

That's ok. We don't have to have perfect parity between WebGL and SVG symbol. Like I said in #1482 (comment), we should just make sure that we don't introduce WebGL-only markers - which I think you did, but we should double check possible by adding a jasmine test.

[etpinard]

Looks like you changed the cross symbol which is breaking the gl3d_marker_arrays and the gl3d_projection_traces mocks.

[destradafilm]

I changed cross back to original symbol, so that means I removed 'cross-thin'

[etpinard]

Thanks. Reverting back to the current symbol is the way to go here.

That said, we could (and should I'd say) make cross thicker and add cross-thin in v2.

[etpinard]

Added to the #420 list of planned breaking changes.

[etpinard]

Ok @destradafilm before merging we should make the new WebGL symbols have image test support.

Can you try adding an scatter3d and scattergl data/layout mock in test/image/mock/ showing off all the new symbols?

If you're up for a challenge, you can also try generating the baseline images using our image test docker container.

[etpinard]

@destradafilm Are you ok with taking care of #1482 (comment) or do you me to do it? This would make a nice addition to next week's 1.26.0.

[destradafilm]

@etpinard I've been too busy in the past few days to work on it. If you're willing to do it, that would be great! If not, it will probably have to be the end of next week before I can get to it.

[etpinard]

@destradafilm no problem. I'll take care of it (should only be a 5-minute job)!

Thanks again for the PR 🍻

[etpinard]

Superseded by #1550