Remove the performance overhead of showLink property

[hy9be]

A fix for: #1554. Do nothing if showLink is set to be false, to avoid performance overhead caused by measuring and reflows.

[etpinard]

This could break graphs that have the showSources config option set as it is called below.

So, replacing this line with something like:

if(!gd._context.showLink||!gd._context.showSources)return;

would be safer.

[hy9be]

Got it. Thanks!

[hy9be]

Code updated according to the review feedback.

[etpinard]

Unfortunately, your latest commit made npm run test-jasmine -- config fail:

[hy9be]

Em, Interesting...I will take a look. Did not run the test locally as I thought it is just a trivial change.

[hy9be]

I changed the OR condition into AND:

if(!gd._context.showLink&&!gd._context.showSources)return;

It seems to make sense to me logically, and all tests pass. But please review. Thanks!

[hy9be]

I cannot reproduce the errors reported by CI. And it does not have information about test cases and lines. Any suggestion on debugging?

[etpinard]

CI uses an older version of Chrome (54, the latest is 57 I think), so maybe that's the issue.

Otherwise, have you tried running all the test suites at once with npm run jasmine? Maybe on test case isn't cleaning up correctly?

[hy9be]

The error doesn't look like related to browser version.

Yes I run the full jasmine test. And only two noCI cases failed:

[hy9be]

Run all the test cases locally again. All 1850 cases passed this time. So I add some comments to re-trigger the CI check.

[etpinard]

@hy9be tests are passing. Looks like the CI failure was intermittent. Our apologies.

Great PR. Thanks againg 🎉

Merging.