Skip to content

Mapbox to image context - #1598

Merged
etpinard merged 2 commits into
masterfrom
mapbox-to-image-context
Apr 14, 2017
Merged

Mapbox to image context#1598
etpinard merged 2 commits into
masterfrom
mapbox-to-image-context

Conversation

@etpinard

@etpinardetpinard commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

fixes#1598

toImage and downloadImage are broken currently for graphs with mapbox subplot and access token set via the config argument in Plotly.plot (e.g. like on plot.ly embed and shareplot).

- so that toImage works when token is set in config
argument.
@etpinardetpinard added this to the v1.26.0 milestone Apr 13, 2017
@etpinard

Copy link
Copy Markdown
ContributorAuthor

@alexcjohnson might as well get this one in 1.26.0 if you don't mind reviewing this.

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Yeah, looks legit to me! 💃

@etpinard
etpinard merged commit 6255f6d into masterApr 14, 2017
@etpinard
etpinard deleted the mapbox-to-image-context branch April 14, 2017 01:12
@etpinardetpinard mentioned this pull request Jun 8, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugsomething broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@alexcjohnson