Skip to content

Bring back click events [fixes #173]#174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 3 commits into from
Jan 11, 2016
Merged

Bring back click events [fixes #173] #174

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
210acac
partial fix for click events:
etpinard Jan 11, 2016
40cc585
bring fx.unhover call to onDone handler
etpinard Jan 11, 2016
026e16e
move fx.unhover call to onMove handler
etpinard Jan 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/plots/cartesian/graph_interact.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1377,7 +1377,6 @@ function dragBox(gd, plotinfo, x, y, w, h, ns, ew) {
yaxes: ya,
doubleclick: doubleClick,
prepFn: function(e, startX, startY) {
fx.unhover(gd); // we want a clear plot for dragging
var dragModeNow = gd._fullLayout.dragmode;
if(ns + ew === 'nsew') {
// main dragger handles all drag modes, and changes
Expand DownExpand Up@@ -2045,7 +2044,10 @@ fx.dragElement = function(options) {

if(Math.abs(dx) < minDrag) dx = 0;
if(Math.abs(dy) < minDrag) dy = 0;
if(dx||dy) gd._dragged = true;
if(dx||dy) {
gd._dragged = true;
fx.unhover(gd);
}

if(options.moveFn) options.moveFn(dx, dy, gd._dragged);

Expand Down