Fix annotation autorange on category axes by etpinard · Pull Request #1791 · plotly/plotly.js

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard · 2017-06-15T19:22:22Z

fixes#1768 by making the category axes setConvert methods a bit more of a mess. Note that annotation autorange uses ax.r2c.

Oh well, with this patch here, it seems like all the cases are covered.

Together with #1748, we now have working category annotations on first draw and on pan/zoom 🎉 :

By the way @alexcjohnson I chose to add a new mock in f5c0382 instead of appending annotation-autorange.json to test shapes on category axes as well. I hope you don't mind.

- fixes annotations autorange - does not appear to have any unwanted side-effects.

alexcjohnson · 2017-06-15T23:54:32Z

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work. No problem about splitting off the mock - you're right to include both x and y, shapes and annotations (what about images?) - though at some point I feel like a bit of consolidation may be in order.

But did that mock fail before the patch? The coordinates that lead to the shape and annotations bumping out the autorange didn't come from category names. For annotations we can use a category that's already in the data and let the text box or arrow add extra pixel padding, for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard · 2017-06-16T19:24:57Z

@alexcjohnson

Nice and simple, and this actually seems like it's the logical way for ax.r2c to work.

Great.

(what about images?)

Layout-image-induced autorange bumps aren't a thing ye (seet #1111) and the layout_image mock already has a category axis. But yeah, when #1111 will be completed, we should add an image or two to category-autorange.json.

But did that mock fail before the patch?

Oops, I messed that up when I added arrows to the mock. Fixed in -> e4aa7a3

for shapes it seems like we may need to use a category that's not in the data, so ax.categoryarray?

Good call here. That actually uncovered another bug. Done in -> aaf12ba

Bonus: annotations and shapes with invalid category coordinates were broken too. Fixed in -> 0758b3b

alexcjohnson · 2017-06-16T22:14:56Z

Beautiful. Gotta love it when all these extra edge cases pop out on fixing related issues.
💃

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

etpinard added 2 commits June 15, 2017 14:57

add category autorange mock for annotations and shapes
f5c0382

make category r2c handle strings values
d411262
- fixes annotations autorange - does not appear to have any unwanted side-effects.

etpinard added status: reviewable bug something broken labels Jun 15, 2017

etpinard added this to the 1.28.0 milestone Jun 15, 2017

etpinard added 3 commits June 16, 2017 15:20

improve category autorange mock
e4aa7a3

use r2c in shapes calc autorange
aaf12ba

convert invalid categories coords to middle of axis range
0758b3b
- same as what Axes.coercePosition does at the defaults step for other axis types - post #1748, we need to handle this at the ax.r2c as the categories are only known after the calc step.

etpinard merged commit 1c38597 into masterJun 19, 2017

etpinard deleted the fix-category-autorange2 branch June 19, 2017 13:57

Uh oh!

Uh oh!

Conversation

etpinard commented Jun 15, 2017

Uh oh!

alexcjohnson commented Jun 15, 2017

Uh oh!

etpinard commented Jun 16, 2017

Uh oh!

alexcjohnson commented Jun 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Jun 15, 2017

Uh oh!

alexcjohnson commented Jun 15, 2017

Uh oh!

etpinard commented Jun 16, 2017

Uh oh!

alexcjohnson commented Jun 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Jun 15, 2017

Uh oh!

alexcjohnson commented Jun 15, 2017

Uh oh!

etpinard commented Jun 16, 2017

Uh oh!

alexcjohnson commented Jun 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Jun 15, 2017

Uh oh!

alexcjohnson commented Jun 15, 2017

Uh oh!

etpinard commented Jun 16, 2017

Uh oh!

alexcjohnson commented Jun 16, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Jun 15, 2017