Granular options for on-chart editing by alexcjohnson · Pull Request #1895 · plotly/plotly.js

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson · 2017-07-18T21:37:46Z

Adds a new config option edits that's an object of all the separate editable interactions you want to enable or disable. The original config.editable should still be a boolean (default false as always) that sets the defaults for all our supported editable interactions, and config.edits can override pieces of it. For example if you only want to enable editing legend entries, and axis titles and moving the legend, you could do:

Plotly.newPlot(gd, data, layout, {
edits: {legendText: true, axisTitleText: true, legendPosition: true}
})

closes#1872

cc @etpinard @geocosmite

I chose to be fairly granular - for example, annotations have three separate flags (annotationText, annotationPosition, and annotationTail, on the idea that for example you might want to allow someone to move an annotation but not change the length/direction of the arrow) but there are some other things we could segment further if desired (axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

etpinard · 2017-07-19T14:02:09Z


 function setPlotContext(gd, config) {
- if(!gd._context) gd._context = Lib.extendFlat({}, Plotly.defaultConfig);
+ if(!gd._context) gd._context = Lib.extendDeep({}, Plotly.defaultConfig);


Nice. Maybe config isn't as poorly tested than I thought.

etpinard · 2017-07-19T14:10:12Z

+ var legendItem = d[0],
+ bg = d3.select(this).select('.legendtoggle');
+
+ bg.call(Drawing.setRect,


lovely commit 🎉

etpinard · 2017-07-19T14:13:47Z

 .classed('annotation-text-g', true);

+ var editTextPosition = edits[options.showarrow ? 'annotationTail' : 'annotationPosition'];
+ var textEvents = options.captureevents || edits.annotationText || editTextPosition;


No need to address this now, but this seems like the right place to reference #1750

etpinard · 2017-07-19T14:29:56Z

+ });
+ })
+ .then(function() {
+ return Plotly.newPlot(gd, data, layout, {


For completeness, calling Plotly.plot instead of Plotly.newPlot would do the same here?

yes, I guess since we don't remove gd._context on purge I could omit data and layout here and that would be equivalent, just changing the config. I've just been tending to avoid Plotly.plot since its effects on existing plots are a little strange.

etpinard · 2017-07-19T14:31:09Z

 gd = createGraphDiv();
+ });
+
+ function initPlot(editFlag) {


Nice tests 🎉

etpinard · 2017-07-19T14:33:35Z

(axisTitleText could be replaced by xaxisTitleText and yaxisTitleText for example). Did I strike the right balance?

I think so 👍

etpinard · 2017-07-19T14:36:46Z

💃

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

alexcjohnson added 3 commits July 18, 2017 09:47

forEach -> for
5500120

DRY-up computeLegendDimensions
9d4b191

optionally split up editable into granular parts
b4e26ae

alexcjohnson added this to the 1.29.0 milestone Jul 18, 2017

alexcjohnson added feature something new status: reviewable labels Jul 18, 2017

extendDeep for defaultConfig so we clone edits and don't modify it
04d49dd

etpinard reviewed Jul 19, 2017
View reviewed changes

Comment threadtest/jasmine/tests/config_test.js
gd = createGraphDiv();
});

function initPlot(editFlag) {
etpinardJul 19, 2017
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 🎉

alexcjohnson merged commit d97a659 into masterJul 19, 2017

alexcjohnson deleted the edit-parts branch July 19, 2017 14:43

etpinard mentioned this pull request Jul 19, 2017
Config options coerce / schema #1188
Closed

Uh oh!

Uh oh!

Conversation

alexcjohnson commented Jul 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etpinard commented Jul 19, 2017

Uh oh!

etpinard commented Jul 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

alexcjohnson commented Jul 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etpinard commented Jul 19, 2017

Uh oh!

etpinard commented Jul 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

alexcjohnson commented Jul 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

etpinard commented Jul 19, 2017

Uh oh!

etpinard commented Jul 19, 2017

Uh oh!

Reviewers