Skip to content

Update es.js#2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcjohnson merged 1 commit into from
Jan 19, 2018
Merged

Update es.js #2268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/locales/es.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ module.exports = {
'Click to enter Plot title': 'Introducir el título de la Gráfica', // plot_api/plot_api.js:579
'Click to enter X axis title': 'Introducir el título del eje X', // plots/plots.js:301
'Click to enter Y axis title': 'Introducir el título del eje Y', // plots/plots.js:302
'Click to enter radial axis title': 'Introducir el título del eje radial',

@n-riescon-riescoJan 19, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit-picking: here I've translated the original radial axis, but I think polar axis is more common.

@alexcjohnsonalexcjohnsonJan 19, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't polar axis ambiguous between angular and radial? Anyway that's a separate discussion, within the existing context this looks great, thanks!

@n-riescon-riescoJan 19, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've just realised that radial axis here is not the actual axis (i.e. the polar axis used as a reference to measure the angular coordinate).

Is there a string to translate for the "angular axis"?
No, there isn't.

'Compare data on hover': 'Comparar datos al pasar por encima', // components/modebar/buttons.js:167
'Double-click on legend to isolate one trace': 'Haga doble-clic en la leyenda para aislar una traza', // components/legend/handle_click.js:90
'Double-click to zoom back out': 'Haga doble-clic para restaurar la escala', // plots/cartesian/dragbox.js:335
Expand DownExpand Up@@ -60,6 +61,7 @@ module.exports = {
'mean:': 'media:', // traces/box/calc.js:133
'median:': 'mediana:', // traces/box/calc.js:128
'min:': 'mín:', // traces/box/calc.js:129
'new text': 'nuevo texto',

@n-riescon-riescoJan 19, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatically, the translation should be texto nuevo (as is insertar un texto nuevo), but in software nuevo texto is more common (I guess this is the result of the influence of the original English).

@alexcjohnsonalexcjohnsonJan 19, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insidious, isn't it 😈

Thanks @n-riesco , I'll merge once I get tests to pass; the new regl code is awesome but it's wreaking havoc on CI right now...

'open:': 'apertura:', // traces/ohlc/transform.js:136
'outgoing flow count:': 'flujo de salida:', // traces/sankey/plot.js:143
'q1:': 'q1:', // traces/box/calc.js:130
Expand Down