') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Add doubleclick events by etpinard · Pull Request #255 · plotly/plotly.js · GitHub
Skip to content

Add doubleclick events - #255

Merged
etpinard merged 15 commits into
masterfrom
emit-doubleclick
Feb 24, 2016
Merged

Add doubleclick events#255
etpinard merged 15 commits into
masterfrom
emit-doubleclick

Conversation

@etpinard

@etpinardetpinard commented Feb 15, 2016

Copy link
Copy Markdown
Contributor

As requested by @cpsievert in plotly/plotly.R#416 .

This PR also introduces jasmine tests for select and lasso event data.

Part of #145

mdtusz
mdtusz reviewed Feb 16, 2016
View reviewed changes
Comment threadtest/jasmine/tests/register_test.js
var Plots = Plotly.Plots;

beforeEach(function() {
this.modulesKeys = Object.keys(Plots.modules);

@mdtuszmdtuszFeb 16, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid using this here?

@etpinardetpinardFeb 16, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

You're not a fan of the jasmine this ?

@mdtuszmdtuszFeb 16, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually on second look, I'm ok with that. Didn't know that it was jasmine convention and that the this is cleared between specs.

@etpinard
add comment about click events simulators
5b1e895
@etpinard
make jasmine describe more explicit
c41a756
@etpinard
try sending hoverdata on double click:
9c19406
- double click on a data pt now (1) fires a click event,
(2) fires a double click event and (3) fires another click event,
with the same event data
- double clicking not on a data pt fires a double click event
with null event data
@etpinard
Merge branch 'master' into emit-doubleclick
e7e0889
@etpinard
move destroyGraphDiv to suite level
848f4a5
@etpinard
send null on plotly_doubleclick events:
4c5103f
- to not introduce more complexity into our
set of event data
@etpinard
make doubleclick in select/lasso mode emit its own event: plotly_dese…
d517c4f
…lect
@etpinard
update click and select tests
90edb18
@mdtusz

mdtusz commented Feb 24, 2016

Copy link
Copy Markdown
Contributor

Looks good. Nice tests too. Seems like closeToArray will get lots of use in the future 🍻

💃

etpinard
etpinard reviewed Feb 24, 2016
View reviewed changes
Comment threadsrc/plots/cartesian/select.js
searchInfo.selectPoints(searchInfo, false);
}

gd.emit('plotly_deselect', null);

@etpinardetpinardFeb 24, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @cpsievert

etpinard added a commit that referenced this pull request Feb 24, 2016
@etpinard
Merge pull request#255from plotly/emit-doubleclick
5d35fd6
Add doubleclick events
@etpinard
etpinard merged commit 5d35fd6 into masterFeb 24, 2016
@etpinard
etpinard deleted the emit-doubleclick branch February 24, 2016 19:09
@cpsievert

cpsievert commented Feb 25, 2016

Copy link
Copy Markdown

💥

@etpinardetpinard mentioned this pull request Nov 14, 2016
Closed
@aravindb26aravindb26 mentioned this pull request Dec 29, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@etpinard@mdtusz@cpsievert