Skip to content

Use isArrayOrTypedArray in gl_format_color.js - #2596

Merged
etpinard merged 1 commit into
masterfrom
gl-format-typed-array-colors
May 1, 2018
Merged

Use isArrayOrTypedArray in gl_format_color.js#2596
etpinard merged 1 commit into
masterfrom
gl-format-typed-array-colors

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

fixes#2591 - one Array.isArray -> Lib.isArrayOrTypedArray that slipped through in #2388

cc @alexcjohnson@dy

@alexcjohnson

Copy link
Copy Markdown
Collaborator

Nice and easy - 💃

No guarantee there aren't others lingering out there... I wonder if we can do something perhaps in the react-noop tests like crawl each figure for numeric arrays, convert them all to typed arrays, and verify that nothing fails? I guess that wouldn't have caught this one though, as it didn't cause an error, just failed to use the array, and it doesn't seem like there's any generic way to tell that other than I guess image tests...

Or we can just let @jmmease tell us what else we missed 😉

@etpinard

Copy link
Copy Markdown
ContributorAuthor

Or we can just let @jmmease tell us what else we missed

This gets my vote 😄

Or this #913 or probably the best solution from #1784 (comment)

@etpinard
etpinard merged commit a22c0d5 into masterMay 1, 2018
@etpinard
etpinard deleted the gl-format-typed-array-colors branch May 1, 2018 17:23
@jonmmease

Copy link
Copy Markdown
Contributor

Works for me 😄

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugsomething broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scattergl marker color behaves unexpectedly when specified as TypedArray

3 participants

@etpinard@alexcjohnson@jonmmease