Uh oh!
There was an error while loading. Please reload this page.
Fix for number 0 treated as invalid in hover (#1) - #2682
Merged
Conversation
dalle
commented
May 30, 2018
Contributor
- treat number 0 as valid in hover fixesTooltip text not working when text is 0 (number) #2660
* treat zero as valid fixesplotly#2660 * PR suggestions: toBe instead of toEqual
alexcjohnson
commented
May 30, 2018
Collaborator
Thanks @dalle - looks perfect! 💃 |
etpinard
commented
May 30, 2018
Contributor
sweet PR @dalle thanks very much 🎉 |
dalle
commented
May 30, 2018
ContributorAuthor
@alexcjohnson@etpinard Thank you for all the praise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.