Skip to content

Fix scatter3d scalar hovertext handling - #2698

Merged
etpinard merged 1 commit into
masterfrom
scatter3d-scalar-hovertext-fix
Jun 6, 2018
Merged

Fix scatter3d scalar hovertext handling#2698
etpinard merged 1 commit into
masterfrom
scatter3d-scalar-hovertext-fix

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

Easy fix cc @alexcjohnson

But: wow, I wish hover from subplot type to another other would be done in a DRYer way 😫

@alexcjohnson

Copy link
Copy Markdown
Collaborator

yep, at some point we should make an attempt to 🌴 it up - will probably uncover and fix a bunch more bugs that way like I did (am doing...) with colorbars in #2681

But nice quick fix 💃

@etpinard

Copy link
Copy Markdown
ContributorAuthor

we should make an attempt to it up

To me, the first step to 🌴 ing this up would be to make all hover-related routines use just _fullData (i.e. no calcdata) so that e.g. scattergl and scatter can share the same hoverPoints method.

@etpinard
etpinard merged commit 8690ee7 into masterJun 6, 2018
@etpinard
etpinard deleted the scatter3d-scalar-hovertext-fix branch June 6, 2018 14:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugsomething broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@alexcjohnson