Better mapbox minification fix by etpinard · Pull Request #2792 · plotly/plotly.js

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard · 2018-07-09T16:50:27Z

fixes#2787, though I wouldn't call it a great fix, but it's probably the best we can do in this repo.

By playing around with terser's compression options (which is the default minifier in our dev-dep minify-stream), I found that setting typeofs: false on bundles that include mapbox-gl fixes#2789. Moreover, I added a test to make sure this doesn't happen again.

With this PR our bundle sizes are back to where they were before #2789.

... and run full compress otherwise.

etpinard · 2018-07-09T16:50:39Z

cc @alexcjohnson

alexcjohnson · 2018-07-09T17:39:19Z

Good find! While we’re at it, would it be worth including all trace types in that test? The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

Also, is it possible to base this flag on whether mapbox is in the bundle definition, rather than naming specific bundles? I wouldn’t want to have to remember this if we add another that includes mapbox. Or should we just leave this option in all bundles? Does it add a noticeable number of bytes? Anyway it says IE10 and below might not like this compression so it may be best to just make it consistent.

- for consistency and maintainability, this does lead to a few extra bytes though.

... for better min.js test coverage

etpinard · 2018-07-09T21:01:28Z

The plot_types mock is a good start, but also may be nice to include parcoords, sankey, table, scattergl...

I hope you like dd8bf6c and 89d7aa8 where I reused the Plotly.react noop test lists. Let's just hope it doesn't add too much time to our CI test runs 🤞

Or should we just leave this option in all bundles? Does it add a noticeable number of bytes?

That's what I went for in the end in 2a3afe7. I find the maintainability gains very nice here. It does adds a few bytes (noticeable in some but not all bundles). For reference, in red is with typeofs compression sizes, in green is w/o:

alexcjohnson · 2018-07-10T05:53:40Z

😍 love it! Funny that in at least one case (Cartesian) minified is bigger but gzipped is smaller this way!?
💃

- to improve log readability - to keep cpu levels somewhat constant throughout run

etpinard · 2018-07-10T15:06:17Z


 jasmine)
 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
+ npm run test-bundle || EXIT_STATE=$?


which gives:

⚖️ 👍
💃 still applies :)

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

etpinard added 2 commits July 9, 2018 12:43

undo 'typeofs' compress for min bundles that include mapbox-gl
1f1e47c
... and run full compress otherwise.

add minified bundle test
7171bc4

etpinard added type: maintenance labels Jul 9, 2018

etpinard added 3 commits July 9, 2018 16:54

turn off 'typeof' compress options for all minify steps
2a3afe7
- for consistency and maintainability, this does lead to a few extra bytes though.

extract all mock lists from plot_api suites
dd8bf6c

use mock list in minified bundle suite
89d7aa8
... for better min.js test coverage

etpinard added 3 commits July 10, 2018 11:05

run test-bundle in series
9ba473d
- to improve log readability - to keep cpu levels somewhat constant throughout run

try adding long timeout (for mapbox)
d1992b4

move test-bundle to jasmine test container
810e91f

etpinard commented Jul 10, 2018
View reviewed changes

etpinard merged commit ab8b922 into masterJul 11, 2018

etpinard deleted the better-mapbox-minification-fix branch July 11, 2018 21:06

etpinard mentioned this pull request Apr 15, 2019
Mapbox subplots aren't displaying in Webpack production mode. #3768
Closed

archmoj mentioned this pull request Jan 28, 2021
Require unminified mapbox-gl for unminified bundles and improve compression of minified bundles #5449
Merged

Uh oh!

Uh oh!

Conversation

etpinard commented Jul 9, 2018

Uh oh!

etpinard commented Jul 9, 2018

Uh oh!

alexcjohnson commented Jul 9, 2018

Uh oh!

etpinard commented Jul 9, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcjohnson commented Jul 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Jul 9, 2018

Uh oh!

etpinard commented Jul 9, 2018

Uh oh!

alexcjohnson commented Jul 9, 2018

Uh oh!

etpinard commented Jul 9, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcjohnson commented Jul 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

etpinard commented Jul 9, 2018

Uh oh!

etpinard commented Jul 9, 2018

Uh oh!

alexcjohnson commented Jul 9, 2018

Uh oh!

etpinard commented Jul 9, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcjohnson commented Jul 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

etpinard commented Jul 9, 2018•
edited
Loading

alexcjohnson commented Jul 10, 2018•
edited
Loading

etpinard commented Jul 9, 2018•
edited
Loading

alexcjohnson commented Jul 10, 2018•
edited
Loading

etpinard commented Jul 9, 2018•
edited
Loading

alexcjohnson commented Jul 10, 2018•
edited
Loading

etpinard commented Jul 9, 2018•
edited
Loading

alexcjohnson commented Jul 10, 2018•
edited
Loading

etpinard commented Jul 9, 2018•
edited
Loading