Uh oh!
There was an error while loading. Please reload this page.
Add missing fields to fullData - #2850
Merged
Merged
Conversation
... instead of clearing them entirely, this is more consistent with what the react-chart-editor expects
- this piece here is called by Colorbar.supplyDefaults, but colorbars do not have a container-wide 'color' attribute unlike axes, so the comparison with layoutAttributes.color was off. - this bug did not affect the baselines as this routine is called again during Colorbar.draw with a set container color.
| var paths = sel.selectAll('path.mean').data(( | ||
| (trace.type === 'box' && trace.boxmean) || | ||
| (trace.type === 'violin' && trace.box && trace.meanline) | ||
| (trace.type === 'violin' && (trace.box || {}).visible && (trace.meanline || {}).visible) |
Collaborator
There was a problem hiding this comment.
can't this just be trace.box.visible && trace.meanline.visible given the changes below?
... this reduces the occurance of intermittent failure in the gl2d_click suite on etpinard's laptop
etpinard
commented
Jul 30, 2018
ContributorAuthor
Editor devs, is adding violins to the chart editor a high priority? If so, I'm thinking of simply mutating the computed |
etpinard
commented
Jul 30, 2018
ContributorAuthor
Ooops, #2850 (comment) was meant for #2834 |
etpinard
commented
Sep 7, 2018
ContributorAuthor
@alexcjohnson this PR isn't enough to cover all the items in #2834, but it does fix a few things. It would be nice to release this in next week's Tagging as reviewable. |
alexcjohnson
commented
Sep 12, 2018
Collaborator
Yep, this is great, no need to wait on the stragglers before merging this. 💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
covers a few items in #2834
Does not yet address pie
marker.colorsand violinspanandbandwidth(see #2834 (comment) for more on that topic).cc @alexcjohnson