Uh oh!
There was an error while loading. Please reload this page.
Fix toSVG for graphs that call Drawing.gradient - #2914
Conversation
- so that we don't have to fiddle with quotes inside of quotes in Snapshot.toSVG - clear corresponding 'style' setting to avoid potential conflicts - adapt toSVG tests
alexcjohnson
commented
Aug 16, 2018
The first solution (extending the
So I guess in the end I'd vote for the |
…le'" - see #2914 (comment) for more info. This reverts commit 1c8017e.
etpinard
commented
Aug 16, 2018
Sounds good. I'll revert 1c8017e so it will remain in git history in case we change our mind later. |
alexcjohnson
commented
Aug 16, 2018
Good call. 💃 |
This PR fixes
toSVG(and hencetoImageanddownloadImage) for graphs with filled colorbars (from #2910) and contour legend items (added in #2891) in "newer" browsers.These bugs are related to double-nested
"inside svg nodestyle- which browsers have a hard time serializing (cc #1697). Why were they unnoticed in their respective PRs: our old nw.js image-server doesn't care about those double-nested".What saved us from releasing these bugs in 1.40.0 is
./tasks/noci_test.shwhich test mapbox and cone mocks using orca (which relies on a much newer version of Chromium) where the mocks with colorbars failed to export.Now, this PR offers two solutions:
The second solution seems to work well, and it leads to 🔪 a fairly big hacky block in
toSVG. Thoughts?