Skip to content

make sankey honor positioning specified by domain.x#2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoinerg merged 2 commits into from
Sep 7, 2018
Merged

make sankey honor positioning specified by domain.x #2984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6e90cb
sankey fix translateX for subplots
antoinerg Sep 7, 2018
5dcdfb4
sankey add baseline for subplots positioning
antoinerg Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/traces/sankey/render.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -172,7 +172,7 @@ function sankeyModel(layout, d, traceIndex) {
valueFormat: valueFormat,
valueSuffix: valueSuffix,
textFont: textFont,
translateX: domain.x[0] * width + layout.margin.l,
translateX: domain.x[0] * layout.width + layout.margin.l,

@alexcjohnsonalexcjohnsonSep 7, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, sankey is so confusing... I was convinced this must be wrong but no, you got it exactly right, sankey just remapped _size into something that looks like _fullLayout and even called it layout for further obfuscation...

plotly.js/src/traces/sankey/plot.js

Lines 257 to 266 in ff3c324

{
width: size.w,
height: size.h,
margin: {
t: size.t,
r: size.r,
b: size.b,
l: size.l
}
},

If you ever feel like untangling a little of this, please do!

translateY: layout.height - domain.y[1] * layout.height + layout.margin.t,
dragParallel: horizontal ? height : width,
dragPerpendicular: horizontal ? width : height,
Expand Down
Binary file addedtest/image/baselines/sankey_subplots.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
46 changes: 46 additions & 0 deletions test/image/mocks/sankey_subplots.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
{
"data": [{
"domain": {
"x": [0, 0.45]
},
"type": "sankey",
"orientation": "h",
"node": {
"line": {
"color": "black"
},
"label": ["el1", "el2", "el3"]
},
"link": {
"source": [0, 2],
"target": [1, 1],
"value": [120, 50],
"label": ["stram1", "stream2"]
}
},
{
"domain": {
"x": [0.55, 1]
},
"type": "sankey",
"orientation": "h",
"node": {
"line": {
"color": "black"
},
"label": ["el4", "el5", "el6"]
},
"link": {
"source": [0, 2],
"target": [1, 1],
"value": [120, 50],
"label": ["stram4", "stream5"]
}
}
],
"layout": {
"title": "Multiple Sankey plots",
"autosize": true,
"showlegend": false
}
}