Uh oh!
There was an error while loading. Please reload this page.
fallback to max-width and max-height if necessary - #3033
Conversation
Uh oh!
There was an error while loading. Please reload this page.
antoinerg
left a comment
There was a problem hiding this comment.
It looks like computedStyle.height will never be greater than computedStyle.maxHeight because it's the computed style ie. css logic was applied.
The problem we're solving here is the rare case where a CSS developer didn't specify the height of the container. In that case, newHeight is 0 and the final height ends up with the default value of 450 which is sometimes too large and overflows the div.
Uh oh!
There was an error while loading. Please reload this page.
etpinard
commented
Sep 25, 2018
Thanks for the info! Let's 💃 |
antoinerg
commented
Sep 25, 2018
Closes #2968 |
Simple fix to issue #2968