Skip to content

Make legend scrollbar valid svg elements - #304

Merged
etpinard merged 1 commit into
masterfrom
fix-pdf-export
Mar 1, 2016
Merged

Make legend scrollbar valid svg elements#304
etpinard merged 1 commit into
masterfrom
fix-pdf-export

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

@mdtusz

Fixes a bug introduced in #243 and discovered on plot.ly pdf and eps image exports.

To be a valid all must have set width and height attributes. From https://validator.w3.org:

image

- to be a valid <svg> all <rect> must have set width
and height attributes.
@mdtusz

Copy link
Copy Markdown
Contributor

💃 once tests are 👍

etpinard added a commit that referenced this pull request Mar 1, 2016
Make legend scrollbar valid svg elements
@etpinard
etpinard merged commit 0456633 into masterMar 1, 2016
@etpinard
etpinard deleted the fix-pdf-export branch March 1, 2016 20:48
@etpinardetpinard mentioned this pull request Mar 1, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@mdtusz