Skip to content

Orthographic projection for 3D plots - #3331

Closed
archmoj wants to merge 24 commits into
masterfrom
ortho-view
Closed

Orthographic projection for 3D plots#3331
archmoj wants to merge 24 commits into
masterfrom
ortho-view

Conversation

@archmoj

Copy link
Copy Markdown
Contributor

Fixes#2611.
A new attribute ortho is defined on the camera object and passed to various modules.
The scene initialisation is now uses the camera init variables and createCamera is centralised in a separate module (i.e. 3d-view) as it was used by plotly.js as well as 3d-view-controls & gl-plot3d modules.
This is a work in progress and some functions such as zooming and restyle require improvements.
Hint: to quickly test the functionality of this feature with existing 3-D mocks, one may change the dflt of ortho to be equal to true.
@etpinard

@etpinardetpinard added this to the v1.45.0 milestone Jan 24, 2019
@etpinard

Copy link
Copy Markdown
Contributor

@archmoj how close is this one to being reviewable?

@archmoj

Copy link
Copy Markdown
ContributorAuthor

@archmoj how close is this one to being reviewable?

@etpinard Please let me resolve the conflicts & clean up the commits in a new PR possibly tomorrow.

@etpinard

Copy link
Copy Markdown
Contributor

& clean up the commits in a new PR possibly tomorrow.

Wanna try to merge master and resolve the conflict instead? Keeping just one PR in our github history. Thanks!

@archmoj

Copy link
Copy Markdown
ContributorAuthor

Now in #3550
Closed.

@archmojarchmoj closed this Feb 18, 2019
@etpinard
etpinard deleted the ortho-view branch February 18, 2019 16:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featuresomething new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@archmoj@etpinard