Uh oh!
There was an error while loading. Please reload this page.
Bar & ErrorBar autorange fixes - #3452
Merged
Merged
Conversation
- 🔪 2-line gaps - consistently call items of `gd.calcdata` -> `calcTraces` in this file!
... and use that option to inherit `tozero` for errorbar findExtremes() call. Update to exiting mocks that were showing wrong behavior.
... this way we can 🔪 min/max logic in Bar.crossTraceCalc which is already done during Axes.getAutoRange.
etpinard
commented
Jan 22, 2019
ContributorAuthor
@archmoj / @antoinerg anyone of you want to take a shot at reviewing this? It's the last PR I'd like included in 1.44.0, I promise 😏 |
archmoj
reviewed
Jan 22, 2019
archmoj
left a comment
Contributor
There was a problem hiding this comment.
Looks robust.
I unsuccessfully tried to break it.
Please find my comment below.
Uh oh!
There was an error while loading. Please reload this page.
archmoj
commented
Jan 22, 2019
Contributor
Well done. |
etpinard
commented
Jan 22, 2019
ContributorAuthor
Thanks for the review @archmoj !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#3031 and #3029 and cleans-up
bar/cross_trace_calc.jsa little bit.Note that commits c14ad69 and b18669d should help if we ever decide to take another shot at making trace attribute
visibleaneditType:'plot'(currently it is acalc, cc #2837, #2849)cc @plotly/plotly_js - best to review this thing commit-by-commit.