Skip to content

Fix category init for non-matching axes on graphs with matching axes - #3565

Merged
etpinard merged 2 commits into
masterfrom
matching-axes-category-and-linear
Feb 21, 2019
Merged

Fix category init for non-matching axes on graphs with matching axes#3565
etpinard merged 2 commits into
masterfrom
matching-axes-category-and-linear

Conversation

@etpinard

@etpinardetpinard commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

archmoj
archmoj reviewed Feb 21, 2019
View reviewed changes

@archmojarchmoj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard Thanks for the PR.
Please find my questions below.

Comment threadsrc/plots/cartesian/set_convert.js Outdated
Comment threadsrc/plots/cartesian/set_convert.js Outdated
@etpinard
improve ax.clearCalc:
598a67b
- mv for-else call after for loop
- rename init() -> emptyCategories()
- break after finding group in which ax is in - as one ax can
only be in a single match group at a time.
@archmoj

archmoj commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Looks good.
💃

@etpinard
etpinard merged commit 9ef8617 into masterFeb 21, 2019
@etpinard
etpinard deleted the matching-axes-category-and-linear branch February 21, 2019 22:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@archmojarchmojarchmoj left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugsomething broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using matches when opposite axis is categorical causes error

2 participants

@etpinard@archmoj