') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); CircleCI: improve caching for faster startup time by antoinerg · Pull Request #3612 · plotly/plotly.js · GitHub
Skip to content

CircleCI: improve caching for faster startup time - #3612

Merged
antoinerg merged 2 commits into
masterfrom
ci-improve-cache
Mar 7, 2019
Merged

CircleCI: improve caching for faster startup time#3612
antoinerg merged 2 commits into
masterfrom
ci-improve-cache

Conversation

@antoinerg

@antoinergantoinerg commented Mar 6, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR slightly improves the execution time of our CircleCi :

  1. I removed the steps to store and restore the cache because they were ineffective (the cache key would never match). We can reintroduce them later if we really want to save off a few seconds out of running npm i.

  2. Instead of doing a long git checkout process for every jobs, we pass the content of the plotly.js directory to subsequent jobs after build. This add rougly 5 seconds to the persist_to_workspace step. However, we reduce the startup time of all the following jobs by ~ 18 seconds:
    newplot 22

This will make running tests in parallel more efficient and save us N * 18 seconds of computation time each run.

@antoinergantoinerg changed the title circleci: 🔪 unused cache key, copy git repo 🐎CircleCI: improve caching for faster startup timeMar 6, 2019
antoinerg
antoinerg commented Mar 7, 2019
View reviewed changes
Comment thread.circleci/config.yml
- checkout
- restore_cache:
keys:
- v{{ .Environment.CIRCLE_CACHE_VERSION }}-deps-{{ .Branch }}-{{ checksum "package-lock.json" }}

@antoinergantoinergMar 7, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice here we use the checksum of "package-lock.json" but when we save the cache, we use the checksum of "package.json". Those two cache names will never match so this is why I removed this "dead" code.

@etpinard

etpinard commented Mar 7, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Nice find. Great work!

I'm curious though: can you try replacing our npm install step with npm ci, and see if we can 🔪 a few more seconds?

@antoinerg

antoinerg commented Mar 7, 2019

Copy link
Copy Markdown
ContributorAuthor

I'm curious though: can you try replacing our npm install step with npm ci, and see if we can hocho a few more seconds?

npm ci seems faster: roughly 6 seconds versus 15-18 seconds for npm i. I will add it to the current PR.

@etpinard

etpinard commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

npm ci seems faster: roughly 6 seconds versus 15-18 seconds for npm i

🎉 !

@antoinerg

antoinerg commented Mar 7, 2019

Copy link
Copy Markdown
ContributorAuthor

Now using npm ci in 98c962d !

@etpinard

etpinard commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

💃 💃

@antoinerg
antoinerg merged commit 7e68a2e into masterMar 7, 2019
@antoinerg
antoinerg deleted the ci-improve-cache branch March 7, 2019 20:05
@alexcjohnson

alexcjohnson commented Mar 7, 2019

Copy link
Copy Markdown
Collaborator

cc @Marc-Andre-Rivet re: npm ci - nice find @etpinard@antoinerg 🏆

@antoinergantoinerg mentioned this pull request Mar 13, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antoinerg@etpinard@alexcjohnson