Use jasmine-core 3.4.0

[etpinard]

resolves#3368 - getting up-to-speed with the latest version of our test framework, which has two new CLI configs:

• random, which randomises the test ordering (N.B. jasmine turns this on by default, but we set it to false by default as this would make many of our tests fail)
• failFast, so we don't need that karma-fail-fast-reporter plugin

About the negateIf commit, see #3368 (comment) for more info.

[archmoj]

Excellent.
💃 💃 💃

On another note, I am wondering about the root of this warning (happening on master/here, both locally & using CI)?

[alexcjohnson]

I am wondering about the root of this warning

this is intentional and has been there forever - though it would be nice to silence it! Pretty sure it's this:

plotly.js/test/jasmine/tests/layout_images_test.js

Lines 324 to 327 in 56f3bb7

	Plotly.relayout(gd,'images[0].source','invalidUrl').then(function(){
	varnewSelection=Plotly.d3.select('image');
	expect(newSelection.size()).toBe(0);
	}).then(done);

[etpinard]

Pretty sure it's this [that layout_images_test.js test]

Yes, that's the one. But the 404: /invalidUrl message comes from

plotly.js/src/components/images/draw.js

Line 111 in 2b4de3e

img.src=d.source;

which is tricky to mock while still testing this handler:

plotly.js/src/components/images/draw.js

Lines 113 to 116 in 2b4de3e

	functionerrorHandler(){
	thisImage.remove();
	resolve();
	}

---

So, I'll pass. I hope you don't find the 404: /invalidUrl message that annoying. If so, please open an issue.

[etpinard]

Fun fact, during the merge commit, all shards in test-jasmine2 and test-jasmine3 passed on the first attempt:

🎉