Fix lakes and rivers geometry on scoped geo subplots

[etpinard]

fixes#4046 (a regression from #3856) with the help of etpinard/sane-topojson#14

[etpinard]

cc @plotly/plotly_js don't attempt to update https://codepen.io/nicolaskruchten/pen/orRBKb?editors=0010 from #4046 to see the new behaviour. We need to first update https://cdn.plot.ly/africa_110m.json and friends.

[etpinard]

You'll notice that scope: 'europe' is also currently having issues with showlakes:true.

[etpinard]

This mock currently looks like:

[etpinard]

Using topojson files from before #3856 fixes the lake polygons, but the scoped rivers were still off, see 7075d13 or diff in 5385673

[archmoj]

It is rather difficult to view & compare the before/after images (with aspect-ratio close to 2) on small monitors. @etpinard would you mind splitting the mock into two mocks?

[etpinard]

@archmoj does this help?

[archmoj]

@etpinard I cannot swipe over the center (mid-height) of the image.
Anyway that's just fine.

[antoinerg]

Thank you @etpinard for the update and the mock

💃

[etpinard]

Is @archmoj ok also with the changes?

Here's the script I used to generate the new mock:

varschema=Plotly.PlotSchema.get()varscopes=schema.layout.layoutAttributes.geo.scope.valuesvarresolutions=[110,50]vartraces=[]varlayout={grid: {rows: scopes.length,columns: resolutions.length},width: 600,height: 1500}vark=0resolutions.forEach((r,i)=>{scopes.forEach((s,j)=>{varid='geo'+(k ? (k+1) : '')traces.push({type: 'scattergeo',geo: id})layout[id]={scope: s,resolution: r,domain: {column: i,row: j},landcolor: "brown",showland: true,lakecolor: "blue",showlakes: true,rivercolor: "blue",showrivers: true}k++})})Plotly.newPlot(gd,traces,layout,{scrollZoom:false})

It should be easy to transpose (i,j) -> (j,i), if that makes it easier to review for you.

[archmoj]

💃