Skip to content

Add showEditInChartStudio config option - #4061

Merged
etpinard merged 6 commits into
masterfrom
showEditInChartStudio
Jul 19, 2019
Merged

Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom
showEditInChartStudio

Conversation

@etpinard

@etpinardetpinard commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

as a supplement to showSendToCloud (ref: #3307)

Demo: https://codepen.io/etpinard/pen/YmzbYG

Peek 2019-07-18 15-27

Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten

@etpinardetpinard added this to the v1.49.0 milestone Jul 18, 2019
etpinard
etpinard commented Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg Outdated
<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>

@etpinardetpinardJul 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form

https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg

@antoinergantoinergJul 19, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062

@etpinard

etpinard commented Jul 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.

Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.

Any objections @plotly/plotly_js ?

@antoinerg

antoinerg commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

Any objections @plotly/plotly_js ?

None from me, feel free to 🔪 !

@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard mentioned this pull request Jul 18, 2019
Merged
@antoinerg

antoinerg commented Jul 19, 2019

Copy link
Copy Markdown
Contributor

Thanks, @etpinard for the nice addition! I like the icon: it's very clear.

💃

@etpinard
etpinard merged commit 56dd829 into masterJul 19, 2019
@etpinard
etpinard deleted the showEditInChartStudio branch July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees

No one assigned

Labels

featuresomething new

Projects

None yet

Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add showEditInChartStudio config option by etpinard · Pull Request #4061 · plotly/plotly.js · GitHub
Skip to content
Add showEditInChartStudio config option - #4061
Merged
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Jul 19, 2019
Merged
Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Conversation
@etpinard
@etpinardetpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
as a supplement to showSendToCloud (ref: #3307)
Demo: https://codepen.io/etpinard/pen/YmzbYG
Peek 2019-07-18 15-27
Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten
@etpinardetpinard
added this to the v1.49.0 milestone
Jul 18, 2019
etpinard
etpinard
commented
Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg
Outdated

<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
@etpinardetpinardJul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form
https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg
@antoinergantoinergJul 19, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062
@etpinard
etpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.
Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.
Any objections @plotly/plotly_js ?
@antoinerg
antoinerg
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Any objections @plotly/plotly_js ?
None from me, feel free to 🔪 !
@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard
mentioned this pull request
Jul 18, 2019
 Merged

@antoinerg
antoinerg
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
Thanks, @etpinard for the nice addition! I like the icon: it's very clear.
💃
@etpinard
etpinard
merged commit 56dd829
into
masterJul 19, 2019
@etpinard
etpinard
deleted the

showEditInChartStudio

branch
July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add showEditInChartStudio config option by etpinard · Pull Request #4061 · plotly/plotly.js · GitHub
Skip to content
Add showEditInChartStudio config option - #4061
Merged
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Jul 19, 2019
Merged
Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Conversation
@etpinard
@etpinardetpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
as a supplement to showSendToCloud (ref: #3307)
Demo: https://codepen.io/etpinard/pen/YmzbYG
Peek 2019-07-18 15-27
Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten
@etpinardetpinard
added this to the v1.49.0 milestone
Jul 18, 2019
etpinard
etpinard
commented
Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg
Outdated

<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
@etpinardetpinardJul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form
https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg
@antoinergantoinergJul 19, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062
@etpinard
etpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.
Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.
Any objections @plotly/plotly_js ?
@antoinerg
antoinerg
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Any objections @plotly/plotly_js ?
None from me, feel free to 🔪 !
@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard
mentioned this pull request
Jul 18, 2019
 Merged

@antoinerg
antoinerg
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
Thanks, @etpinard for the nice addition! I like the icon: it's very clear.
💃
@etpinard
etpinard
merged commit 56dd829
into
masterJul 19, 2019
@etpinard
etpinard
deleted the

showEditInChartStudio

branch
July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add showEditInChartStudio config option by etpinard · Pull Request #4061 · plotly/plotly.js · GitHub
Skip to content
Add showEditInChartStudio config option - #4061
Merged
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Jul 19, 2019
Merged
Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Conversation
@etpinard
@etpinardetpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
as a supplement to showSendToCloud (ref: #3307)
Demo: https://codepen.io/etpinard/pen/YmzbYG
Peek 2019-07-18 15-27
Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten
@etpinardetpinard
added this to the v1.49.0 milestone
Jul 18, 2019
etpinard
etpinard
commented
Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg
Outdated

<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
@etpinardetpinardJul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form
https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg
@antoinergantoinergJul 19, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062
@etpinard
etpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.
Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.
Any objections @plotly/plotly_js ?
@antoinerg
antoinerg
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Any objections @plotly/plotly_js ?
None from me, feel free to 🔪 !
@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard
mentioned this pull request
Jul 18, 2019
 Merged

@antoinerg
antoinerg
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
Thanks, @etpinard for the nice addition! I like the icon: it's very clear.
💃
@etpinard
etpinard
merged commit 56dd829
into
masterJul 19, 2019
@etpinard
etpinard
deleted the

showEditInChartStudio

branch
July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add showEditInChartStudio config option by etpinard · Pull Request #4061 · plotly/plotly.js · GitHub
Skip to content
Add showEditInChartStudio config option - #4061
Merged
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Jul 19, 2019
Merged
Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Conversation
@etpinard
@etpinardetpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
as a supplement to showSendToCloud (ref: #3307)
Demo: https://codepen.io/etpinard/pen/YmzbYG
Peek 2019-07-18 15-27
Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten
@etpinardetpinard
added this to the v1.49.0 milestone
Jul 18, 2019
etpinard
etpinard
commented
Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg
Outdated

<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
@etpinardetpinardJul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form
https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg
@antoinergantoinergJul 19, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062
@etpinard
etpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.
Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.
Any objections @plotly/plotly_js ?
@antoinerg
antoinerg
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Any objections @plotly/plotly_js ?
None from me, feel free to 🔪 !
@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard
mentioned this pull request
Jul 18, 2019
 Merged

@antoinerg
antoinerg
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
Thanks, @etpinard for the nice addition! I like the icon: it's very clear.
💃
@etpinard
etpinard
merged commit 56dd829
into
masterJul 19, 2019
@etpinard
etpinard
deleted the

showEditInChartStudio

branch
July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add showEditInChartStudio config option by etpinard · Pull Request #4061 · plotly/plotly.js · GitHub
Skip to content
Add showEditInChartStudio config option - #4061
Merged
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Jul 19, 2019
Merged
Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Conversation
@etpinard
@etpinardetpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
as a supplement to showSendToCloud (ref: #3307)
Demo: https://codepen.io/etpinard/pen/YmzbYG
Peek 2019-07-18 15-27
Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten
@etpinardetpinard
added this to the v1.49.0 milestone
Jul 18, 2019
etpinard
etpinard
commented
Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg
Outdated

<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
@etpinardetpinardJul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form
https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg
@antoinergantoinergJul 19, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062
@etpinard
etpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.
Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.
Any objections @plotly/plotly_js ?
@antoinerg
antoinerg
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Any objections @plotly/plotly_js ?
None from me, feel free to 🔪 !
@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard
mentioned this pull request
Jul 18, 2019
 Merged

@antoinerg
antoinerg
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
Thanks, @etpinard for the nice addition! I like the icon: it's very clear.
💃
@etpinard
etpinard
merged commit 56dd829
into
masterJul 19, 2019
@etpinard
etpinard
deleted the

showEditInChartStudio

branch
July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add showEditInChartStudio config option by etpinard · Pull Request #4061 · plotly/plotly.js · GitHub
Skip to content
Add showEditInChartStudio config option - #4061
Merged
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Jul 19, 2019
Merged
Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Conversation
@etpinard
@etpinardetpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
as a supplement to showSendToCloud (ref: #3307)
Demo: https://codepen.io/etpinard/pen/YmzbYG
Peek 2019-07-18 15-27
Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten
@etpinardetpinard
added this to the v1.49.0 milestone
Jul 18, 2019
etpinard
etpinard
commented
Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg
Outdated

<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
@etpinardetpinardJul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form
https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg
@antoinergantoinergJul 19, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062
@etpinard
etpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.
Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.
Any objections @plotly/plotly_js ?
@antoinerg
antoinerg
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Any objections @plotly/plotly_js ?
None from me, feel free to 🔪 !
@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard
mentioned this pull request
Jul 18, 2019
 Merged

@antoinerg
antoinerg
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
Thanks, @etpinard for the nice addition! I like the icon: it's very clear.
💃
@etpinard
etpinard
merged commit 56dd829
into
masterJul 19, 2019
@etpinard
etpinard
deleted the

showEditInChartStudio

branch
July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add showEditInChartStudio config option by etpinard · Pull Request #4061 · plotly/plotly.js · GitHub
Skip to content
Add showEditInChartStudio config option - #4061
Merged
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Jul 19, 2019
Merged
Add showEditInChartStudio config option#4061
etpinard merged 6 commits into
masterfrom 
showEditInChartStudio
Conversation
@etpinard
@etpinardetpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
as a supplement to showSendToCloud (ref: #3307)
Demo: https://codepen.io/etpinard/pen/YmzbYG
Peek 2019-07-18 15-27
Required for 1.49.0 - cc @plotly/plotly_js @nicolaskruchten
@etpinardetpinard
added this to the v1.49.0 milestone
Jul 18, 2019
etpinard
etpinard
commented
Jul 18, 2019
View reviewed changes
Comment threadsrc/fonts/ploticon/ploticon.svg
Outdated

<glyph glyph-name="lasso" unicode="&#xe811;" d="m1018 538c-36 207-290 336-568 286-277-48-473-256-436-463 10-57 36-108 76-151-13-66 11-137 68-183 34-28 75-41 114-42l-55-70 0 0c-2-1-3-2-4-3-10-14-8-34 5-45 14-11 34-8 45 4 1 1 2 3 2 5l0 0 113 140c16 11 31 24 45 40 4 3 6 7 8 11 48-3 100 0 151 9 278 48 473 255 436 462z m-624-379c-80 14-149 48-197 96 42 42 109 47 156 9 33-26 47-66 41-105z m-187-74c-19 16-33 37-39 60 50-32 109-55 174-68-42-25-95-24-135 8z m360 75c-34-7-69-9-102-8 8 62-16 128-68 170-73 59-175 54-244-5-9 20-16 40-20 61-28 159 121 317 333 354s407-60 434-217c28-159-121-318-333-355z" horiz-adv-x="1031" />
<glyph glyph-name="selectbox" unicode="&#xe812;" d="m0 850l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-285l0-143 143 0 0 143-143 0z m857 0l0-143 143 0 0 143-143 0z m-857-286l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z m285 0l0-143 143 0 0 143-143 0z m286 0l0-143 143 0 0 143-143 0z" horiz-adv-x="1000" />
<glyph glyph-name="spikeline" unicode="&#57408;" d="M512 409c0-57-46-104-103-104-57 0-104 47-104 104 0 57 47 103 104 103 57 0 103-46 103-103z m-327-39l92 0 0 92-92 0z m-185 0l92 0 0 92-92 0z m370-186l92 0 0 93-92 0z m0-184l92 0 0 92-92 0z"/>
<glyph glyph-name="pencil" unicode="&#x270E;" horiz-adv-x="1792" vert-adv-y="1792" d="M491 1536l91-91-235-235-91 91v107h128v128h107zm523-928q0-22-22-22-10 0-17 7l-542 542q-7 7-7 17 0 22 22 22 10 0 17-7l542-542q7-7 7-17zm-54-192l416 416-832 832h-416v-416zm683 96q0 53-37 90l-166 166-416-416 166-165q36-38 90-38 53 0 91 38l235 234q37 39 37 91z"/>
@etpinardetpinardJul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken form
https://github.com/encharm/Font-Awesome-SVG-PNG/blob/master/black/svg/pencil.svg
@antoinergantoinergJul 19, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be deleted in #4062
@etpinard
etpinard
commented
Jul 18, 2019

Copy link


Copy Markdown

ContributorAuthor
Oh and while doing this, I noticed that all the files in src/fonts/ploticon/ except for src/fonts/ploticon/ploticon.svg are not used anymore. I believe they are artifacts from our font-awesome account and/or pre-open-source days.
Moreover, since we don't appear to use our font-awesome account to add new icons (e.g. in #1461 and #3068), I'm thinking of dropping the ploticon build step (mostly in tasks/util/pull_font_svg.js) altogether. To add icons we would simply have to modify the build/ploticon.js file by hand.
Any objections @plotly/plotly_js ?
@antoinerg
antoinerg
commented
Jul 18, 2019

Copy link


Copy Markdown

Contributor
Any objections @plotly/plotly_js ?
None from me, feel free to 🔪 !
@etpinard
mv build/ploticon.js -> src/fonts/ploticon.js
10b94bc
 where we now expect devs to update icon definitions "by hand",
w/o the use of `npm run preprocess`
@etpinard
🔪 src/fonts/ploticon/
6e50d82
 all required svg-icon things are in the
`src/fonts/ploticon.js` file
@etpinard
🔪 pull_font_svg preprocess step
f4cf8c0
@etpinardetpinard
mentioned this pull request
Jul 18, 2019
 Merged

@antoinerg
antoinerg
commented
Jul 19, 2019

Copy link


Copy Markdown

Contributor
Thanks, @etpinard for the nice addition! I like the icon: it's very clear.
💃
@etpinard
etpinard
merged commit 56dd829
into
masterJul 19, 2019
@etpinard
etpinard
deleted the

showEditInChartStudio

branch
July 19, 2019 19:52
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antoinergantoinergantoinerg left review comments

Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.49.0

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@antoinerg