Skip to content

Bump mapbox-gl to v1.3.2 - #4230

Merged
etpinard merged 4 commits into
masterfrom
bump-mapboxgl
Sep 30, 2019
Merged

Bump mapbox-gl to v1.3.2#4230
etpinard merged 4 commits into
masterfrom
bump-mapboxgl

Conversation

@etpinardetpinard added this to the v1.50.0 milestone Sep 27, 2019
@etpinardetpinard changed the title Bump mapbox-glBump mapbox-gl to v1.3.2Sep 27, 2019
@etpinard

etpinard commented Sep 27, 2019

Copy link
Copy Markdown
ContributorAuthor

Note that mapbox-gl now allows users to set their access tokens per map as opposed to during module instantiation (in mapbox/mapbox-gl-js#8364).

This means that we could implement a way to plot multiple mapbox subplots with different mapbox access token on the same plotly.js graph.

//
// Need a 10ms delay (0ms should suffice to skip a thread in the
// render loop) to workaround mapbox-gl bug introduced in v1.3.0
setTimeout(resolve, 10);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archmoj w/o this extra 10ms delay, call sequences like

// off the `mapbox_0` mockPlotly.restyle(gd,'visible',false).then(()=>Plotly.restyle(gd,'visible',true)).then(()=>Plotly.restyle(gd,'visible','legendonly',[1]))

fails and logs

image


I suspect this is caused by mapbox/mapbox-gl-js#8633 - but I haven't investigated further.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll leave this conversation open so that it is noticed by in the QA.

@etpinard

Copy link
Copy Markdown
ContributorAuthor

Looks like we'll also need 422d5d3 to make test-image pass on this branch - cc #4227 (comment)


Let's wait a little bit before. Ideally, I would merge master into this branch after #4219 gets merged.

@archmoj

Copy link
Copy Markdown
Contributor

@etpinard thanks very much for the PR.
💃

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@etpinard@archmoj