Uh oh!
There was an error while loading. Please reload this page.
Move bar transform functions to bar helpers - #4391
Conversation
etpinard
commented
Nov 29, 2019
I'm not sure I approve. For example, plotly.js/src/traces/pie/helpers.js Lines 37 to 40 in dbf02f1 is called in plotly.js/src/traces/pie/plot.js Line 79 in dbf02f1 plotly.js/src/traces/pie/style_one.js Lines 16 to 17 in dbf02f1 So, I don't see anything wrong with keeping all bar "plotting" subroutines in |
archmoj
commented
Nov 29, 2019
I see the point that |
etpinard
commented
Nov 29, 2019
I vote for leaving them in |
Before addressing #4247
this PR remove bar transform functions namely
toMoveInsideBar&toMoveOutsideBarfrombar/plottobar/helpersas those function are required by traces e.g.treemap.This can also help make bar plot code (which used by
histogram,funnelandwaterfall) more compact.@plotly/plotly_js