Skip to content

Fix colorbar of reversescale colorbars of heatmap-coloring contours - #4437

Merged
etpinard merged 2 commits into
masterfrom
contour-heatmap-coloring-colorscale-reversescale-fix
Dec 20, 2019
Merged

Fix colorbar of reversescale colorbars of heatmap-coloring contours#4437
etpinard merged 2 commits into
masterfrom
contour-heatmap-coloring-colorscale-reversescale-fix

Conversation

@etpinard

@etpinardetpinard commented Dec 20, 2019

Copy link
Copy Markdown
Contributor

@archmoj

Copy link
Copy Markdown
Contributor

Great! Could you please add a test for the case of using coloraxis as well?

@etpinard

Copy link
Copy Markdown
ContributorAuthor

Ok I'll add a subplot on the new mock.

But in my opinion, we don't need that as the trace-colorscale vs coloraxis logic is inside Colorscale.extractOpts which is already tested elsewhere.

@archmoj

Copy link
Copy Markdown
Contributor

If so, just testing in a codepen is enough.
Thank you!

@archmoj

Copy link
Copy Markdown
Contributor

Concerning before codepen it is better to use v.1.51.3 not the latest.

@etpinard

Copy link
Copy Markdown
ContributorAuthor

Concerning before codepen it is better to use v.1.51.3 not the latest.

Sure, edited above.

Great! Could you please add a test for the case of using coloraxis as well?

done in af025a2

@archmoj

Copy link
Copy Markdown
Contributor

💃 💃 after all green light on the CI.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugsomething broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reversescale doesn't reverse colorbar on contour plot with coloring='heatmap'

2 participants

@etpinard@archmoj