Uh oh!
There was an error while loading. Please reload this page.
Fix colorbar of reversescale colorbars of heatmap-coloring contours - #4437
Merged
etpinard merged 2 commits intoDec 20, 2019
Merged
Conversation
archmoj
commented
Dec 20, 2019
Contributor
Great! Could you please add a test for the case of using coloraxis as well? |
etpinard
commented
Dec 20, 2019
ContributorAuthor
Ok I'll add a subplot on the new mock. But in my opinion, we don't need that as the trace-colorscale vs coloraxis logic is inside |
archmoj
commented
Dec 20, 2019
Contributor
If so, just testing in a codepen is enough. |
archmoj
commented
Dec 20, 2019
Contributor
Concerning |
etpinard
commented
Dec 20, 2019
ContributorAuthor
Sure, edited above.
done in af025a2 |
archmoj
commented
Dec 20, 2019
Contributor
💃 💃 after all green light on the CI. |
etpinard
deleted the
contour-heatmap-coloring-colorscale-reversescale-fix
branch
December 20, 2019 22:24
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#4430
before: https://codepen.io/etpinard/pen/ZEYePxW
after: https://codepen.io/etpinard/pen/JjoWzYb
cc @archmoj