Fix - hide empty bars in interactive mode

[archmoj]

Fixes#4499

before vs after

@plotly/plotly_js

[etpinard]

Thanks @archmoj for the quick fix. After some testing, looks like the behaviour is now correct. I am a little worried though about how complex the logic in bar/plot.js has become.

At the very least, we should add two new variables to make the logic easier to digest:

• one for isHorizontal && (x1 - x0 !== 0) e.g. setting a variable named spanHorizontal
• one for !isHorizontal && (y1 - y0 !== 0) e.g. " " " " spansVertical

which could be in

// display zeros if line.width > 0if(isBlank&&shouldDisplayZeros&&helpers.getLineWidth(trace,di)&&(isHorizontal ? x1-x0===0 : y1-y0===0)){isBlank=false;}

and below in

if(!gd._context.staticPlot){// ...if(spansHorizontal){x0=fixpx(x0,x1);x1=fixpx(x1,x0);}if(spansVertical){y0=fixpx(y0,y1);y1=fixpx(y1,y0);}}

instead of monkey-patching the expandVisible helper for the degenerate case.

---

Does that sound ok to you @archmoj ?

[archmoj]

@etpinard that makes sense.
Alternatively we may consider adding "only" this line:

if(v===vc)returnv;

to expandToVisible function without adding extra logic to bar.

[etpinard]

Alternatively we may consider adding "only" this line:

if(v===vc)returnv;

Hmm. Wouldn't that defeat the purpose of expandVisible? Right now, if v === vc, v gets floored or ceiled.

[etpinard]

... and unfortunately we can't rely on the image tests here as this piece of logic in inside a !gd._context.staticPlot block.

[archmoj]

OK. Addressing your #4522 (comment) sounds the safest fix.

[etpinard]

Yep, that's a step in the right direction - thanks 💃