Skip to content

Fix4631 - handle NaN cases to allow breaks on bar-like traces - #4634

Merged
archmoj merged 2 commits into
masterfrom
fix4631-bar-handle-nan
Mar 12, 2020
Merged

Fix4631 - handle NaN cases to allow breaks on bar-like traces#4634
archmoj merged 2 commits into
masterfrom
fix4631-bar-handle-nan

Conversation

@archmoj

@archmojarchmoj commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

Fixes#4631.

before
after

@plotly/plotly_js

@archmojarchmoj added bug something broken status: reviewable regression this used to work labels Mar 12, 2020
@archmojarchmoj added this to the v1.53.0 milestone Mar 12, 2020
alexcjohnson
alexcjohnson approved these changes Mar 12, 2020
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that works! 💃

@archmoj
archmoj merged commit c5173e1 into masterMar 12, 2020
@archmoj
archmoj deleted the fix4631-bar-handle-nan branch March 12, 2020 18:04
@archmojarchmoj mentioned this pull request Mar 12, 2020
Merged
@snyk-botsnyk-bot mentioned this pull request Apr 23, 2020
Open
@snyk-botsnyk-bot mentioned this pull request May 1, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

No one assigned

Labels

bugsomething brokenregressionthis used to work

Projects

None yet

Milestone

v1.53.0

Development

Successfully merging this pull request may close these issues.

Bars with NaNs as positions lead to console errors

2 participants

@archmoj@alexcjohnson