Skip to content

rename axis.breaks to axis.rangebreaks - #4641

Merged
archmoj merged 2 commits into
masterfrom
rename-breaks-to-rangebreaks
Mar 14, 2020
Merged

rename axis.breaks to axis.rangebreaks#4641
archmoj merged 2 commits into
masterfrom
rename-breaks-to-rangebreaks

Conversation

@archmoj

@archmojarchmoj commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Follow up of feature added in #4614 for v1.53.0
Fixes codegen noting that break is a reserved keyword in python.

@plotly/plotly_js

@archmojarchmoj added bug something broken feature something new status: reviewable labels Mar 14, 2020
@archmojarchmoj added this to the v1.53.0 milestone Mar 14, 2020
alexcjohnson
alexcjohnson reviewed Mar 14, 2020
View reviewed changes
Comment threadsrc/plots/cartesian/layout_attributes.js Outdated
alexcjohnson
alexcjohnson reviewed Mar 14, 2020
View reviewed changes
Comment threadsrc/plots/cartesian/layout_attributes.js Outdated
alexcjohnson
alexcjohnson reviewed Mar 14, 2020
View reviewed changes
Comment threadsrc/plots/cartesian/layout_attributes.js Outdated
alexcjohnson
alexcjohnson reviewed Mar 14, 2020
View reviewed changes
Comment threadsrc/plots/cartesian/layout_attributes.js
editType: 'calc',
description: [
'Sets the lower and upper bounds of this axis break.',
'Sets the lower and upper bounds of this axis rangebreak.',

@alexcjohnsonalexcjohnsonMar 14, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm somehow as a noun I'm ambivalent about it - probably I'd change the noun usages in descriptions back to break(s) but it's not as clear to me as when break is a verb...

alexcjohnson
alexcjohnson reviewed Mar 14, 2020
View reviewed changes
Comment threadsrc/plots/gl2d/camera.js Outdated
alexcjohnson
alexcjohnson approved these changes Mar 14, 2020
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj
archmoj merged commit dff40cc into masterMar 14, 2020
@archmoj
archmoj deleted the rename-breaks-to-rangebreaks branch March 14, 2020 23:40
@snyk-botsnyk-bot mentioned this pull request Apr 23, 2020
Open
@snyk-botsnyk-bot mentioned this pull request May 1, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

No one assigned

Labels

bugsomething brokenfeaturesomething new

Projects

None yet

Milestone

v1.53.0

Development

Successfully merging this pull request may close these issues.

2 participants

@archmoj@alexcjohnson