Skip to content

Fix to display transparent surface with contours when opacity is less than one - #4642

Merged
archmoj merged 3 commits into
masterfrom
surface-with-contour-and-opacity
Mar 15, 2020
Merged

Fix to display transparent surface with contours when opacity is less than one #4642
archmoj merged 3 commits into
masterfrom
surface-with-contour-and-opacity

Conversation

@archmoj

@archmojarchmoj commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

Fixes a bug introduced in #4480 to avoid regression in v1.53.0.
As illustrated in this codepen the surface with opacity < 1 and contours was not displayed transparent!

@plotly/plotly_js

@archmojarchmoj added this to the v1.53.0 milestone Mar 15, 2020
archmoj
archmoj commented Mar 15, 2020
View reviewed changes
Comment threadpackage.json Outdated
alexcjohnson
alexcjohnson approved these changes Mar 15, 2020
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj
archmoj merged commit 879b006 into masterMar 15, 2020
@archmoj
archmoj deleted the surface-with-contour-and-opacity branch March 15, 2020 13:19
@snyk-botsnyk-bot mentioned this pull request Apr 23, 2020
Open
@snyk-botsnyk-bot mentioned this pull request May 1, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

No one assigned

Labels

bugsomething broken

Projects

None yet

Milestone

v1.53.0

Development

Successfully merging this pull request may close these issues.

2 participants

@archmoj@alexcjohnson