Avoid tight daily labels on axes with rangebreaks when using "day of week" pattern

[archmoj]

Demo

Follow up of #4614 and #4688:
Commit c340efc exercised 2 -> 7 rounding which leads to following commits.

As a result we only round dtick to 1 if it is really close to 1.

@plotly/plotly_js

[nicolaskruchten]

Hmm yeah that mock does seem sparse. But I think erring on the side of sparseness is better than sometimes having unreadably-dense plots like this one:

[archmoj]

Hmm yeah that mock does seem sparse. But I think erring on the side of sparseness is better than sometimes having unreadably-dense plots like this one:

@nicolaskruchten thanks very much for posting the image related to the ( old ) undesirable behaviour.

[alexcjohnson]

Is this different from just saying roundDTick(roughDTick, ONEDAY, [1, 7, 14])? The underlying function is Lib.roundUp so I'd expect anything too big for 1 would already bump up to 7. Also I think this would convert 2-week ticks into 1-week?

[archmoj]

Also I think this would convert 2-week ticks into 1-week?

Doog eye. Fixed in 79b6d95.

But we still need to fix something possibly in Lib.dateTick0 to compute dtick on those reversed cases.

[alexcjohnson]

again though, is this different from just roundDTick(roughDTick, ONEDAY, [1, 7, 14])?

[archmoj]

I think that is different. The issue was almost related to numbers close to 1 (e.g. 2) not those close to 7. Anyway it seems there is no more need for that hacy roundingSet as the logic is changed in the commits below.

[archmoj]

@nicolaskruchten would you mind testing the updated demo in the PR description.
Thanks!

[alexcjohnson]

💃 sometimes the simple solution is the best 😅