Apply and ensure stroke event only to activate editable shapes by archmoj · Pull Request #4810 · plotly/plotly.js

archmoj · 2020-05-04T19:08:57Z

Fixes#4806 and fixes#4808~~also now one could strat drawing over shapes no matter what the opacity of the below shape is~~.

Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv

@plotly/plotly_js
@emmanuelle

…e editable shapes

alexcjohnson · 2020-05-04T19:22:38Z

 setupDragElement(gd, path, options, index, shapeLayer, editHelpers);
+ } else {
+ if(options.editable === true) {
+ path.style('pointer-events', 'stroke');


As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.

Revised in 078c007.

alexcjohnson · 2020-05-04T21:00:02Z

+ }
+ }
+ ]
+ }, onfig: {


Suggested change
},onfig: {
},config: {

typo of the week

alexcjohnson

Fantastic! Just one little typo to fix and this should be ready! 💃

nicolaskruchten · 2020-05-05T15:14:14Z

@archmoj re:

now one could strat drawing over shapes no matter what the opacity of the below shape is.

do we need to change one of the schema attribute descriptions to match this? I can't remember.

archmoj · 2020-05-05T15:17:58Z

@archmoj re:
now one could strat drawing over shapes no matter what the opacity of the below shape is.
do we need to change one of the schema attribute descriptions to match this? I can't remember.

@nicolaskruchten
No. It was before applying 078c007
in respect to @alexcjohnson's #4810 (comment).
The PR description is modified above.

archmoj · 2020-05-04T19:08:57Z

Fixes#4806 and fixes#4808~~also now one could strat drawing over shapes no matter what the opacity of the below shape is~~.

Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv

@plotly/plotly_js
@emmanuelle

…e editable shapes

alexcjohnson · 2020-05-04T19:22:38Z

 setupDragElement(gd, path, options, index, shapeLayer, editHelpers);
+ } else {
+ if(options.editable === true) {
+ path.style('pointer-events', 'stroke');


As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.

Revised in 078c007.

alexcjohnson · 2020-05-04T21:00:02Z

+ }
+ }
+ ]
+ }, onfig: {


Suggested change
},onfig: {
},config: {

typo of the week

alexcjohnson

Fantastic! Just one little typo to fix and this should be ready! 💃

nicolaskruchten · 2020-05-05T15:14:14Z

@archmoj re:

now one could strat drawing over shapes no matter what the opacity of the below shape is.

do we need to change one of the schema attribute descriptions to match this? I can't remember.

archmoj · 2020-05-05T15:17:58Z

@archmoj re:
now one could strat drawing over shapes no matter what the opacity of the below shape is.
do we need to change one of the schema attribute descriptions to match this? I can't remember.

@nicolaskruchten
No. It was before applying 078c007
in respect to @alexcjohnson's #4810 (comment).
The PR description is modified above.

archmoj · 2020-05-04T19:08:57Z

Fixes#4806 and fixes#4808~~also now one could strat drawing over shapes no matter what the opacity of the below shape is~~.

Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv

@plotly/plotly_js
@emmanuelle

…e editable shapes

alexcjohnson · 2020-05-04T19:22:38Z

 setupDragElement(gd, path, options, index, shapeLayer, editHelpers);
+ } else {
+ if(options.editable === true) {
+ path.style('pointer-events', 'stroke');


As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.

Revised in 078c007.

alexcjohnson · 2020-05-04T21:00:02Z

+ }
+ }
+ ]
+ }, onfig: {


Suggested change
},onfig: {
},config: {

typo of the week

alexcjohnson

Fantastic! Just one little typo to fix and this should be ready! 💃

nicolaskruchten · 2020-05-05T15:14:14Z

@archmoj re:

now one could strat drawing over shapes no matter what the opacity of the below shape is.

do we need to change one of the schema attribute descriptions to match this? I can't remember.

archmoj · 2020-05-05T15:17:58Z

@archmoj re:
now one could strat drawing over shapes no matter what the opacity of the below shape is.
do we need to change one of the schema attribute descriptions to match this? I can't remember.

@nicolaskruchten
No. It was before applying 078c007
in respect to @alexcjohnson's #4810 (comment).
The PR description is modified above.

archmoj · 2020-05-04T19:08:57Z

Fixes#4806 and fixes#4808~~also now one could strat drawing over shapes no matter what the opacity of the below shape is~~.

Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv

@plotly/plotly_js
@emmanuelle

…e editable shapes

alexcjohnson · 2020-05-04T19:22:38Z

 setupDragElement(gd, path, options, index, shapeLayer, editHelpers);
+ } else {
+ if(options.editable === true) {
+ path.style('pointer-events', 'stroke');


As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.

Revised in 078c007.

alexcjohnson · 2020-05-04T21:00:02Z

+ }
+ }
+ ]
+ }, onfig: {


Suggested change
},onfig: {
},config: {

typo of the week

alexcjohnson

Fantastic! Just one little typo to fix and this should be ready! 💃

nicolaskruchten · 2020-05-05T15:14:14Z

@archmoj re:

now one could strat drawing over shapes no matter what the opacity of the below shape is.

do we need to change one of the schema attribute descriptions to match this? I can't remember.

archmoj · 2020-05-05T15:17:58Z

@archmoj re:
now one could strat drawing over shapes no matter what the opacity of the below shape is.
do we need to change one of the schema attribute descriptions to match this? I can't remember.

@nicolaskruchten
No. It was before applying 078c007
in respect to @alexcjohnson's #4810 (comment).
The PR description is modified above.

archmoj · 2020-05-04T19:08:57Z

Fixes#4806 and fixes#4808~~also now one could strat drawing over shapes no matter what the opacity of the below shape is~~.

Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv

@plotly/plotly_js
@emmanuelle

…e editable shapes

alexcjohnson · 2020-05-04T19:22:38Z

 setupDragElement(gd, path, options, index, shapeLayer, editHelpers);
+ } else {
+ if(options.editable === true) {
+ path.style('pointer-events', 'stroke');


As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.

Revised in 078c007.

alexcjohnson · 2020-05-04T21:00:02Z

+ }
+ }
+ ]
+ }, onfig: {


Suggested change
},onfig: {
},config: {

typo of the week

alexcjohnson

Fantastic! Just one little typo to fix and this should be ready! 💃

nicolaskruchten · 2020-05-05T15:14:14Z

@archmoj re:

now one could strat drawing over shapes no matter what the opacity of the below shape is.

do we need to change one of the schema attribute descriptions to match this? I can't remember.

archmoj · 2020-05-05T15:17:58Z

@archmoj re:
now one could strat drawing over shapes no matter what the opacity of the below shape is.
do we need to change one of the schema attribute descriptions to match this? I can't remember.

@nicolaskruchten
No. It was before applying 078c007
in respect to @alexcjohnson's #4810 (comment).
The PR description is modified above.

archmoj · 2020-05-04T19:08:57Z

Fixes#4806 and fixes#4808~~also now one could strat drawing over shapes no matter what the opacity of the below shape is~~.

Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv

@plotly/plotly_js
@emmanuelle

…e editable shapes

alexcjohnson · 2020-05-04T19:22:38Z

 setupDragElement(gd, path, options, index, shapeLayer, editHelpers);
+ } else {
+ if(options.editable === true) {
+ path.style('pointer-events', 'stroke');


As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.

Revised in 078c007.

alexcjohnson · 2020-05-04T21:00:02Z

+ }
+ }
+ ]
+ }, onfig: {


Suggested change
},onfig: {
},config: {

typo of the week

alexcjohnson

Fantastic! Just one little typo to fix and this should be ready! 💃

nicolaskruchten · 2020-05-05T15:14:14Z

@archmoj re:

now one could strat drawing over shapes no matter what the opacity of the below shape is.

do we need to change one of the schema attribute descriptions to match this? I can't remember.

archmoj · 2020-05-05T15:17:58Z

@archmoj re:
now one could strat drawing over shapes no matter what the opacity of the below shape is.
do we need to change one of the schema attribute descriptions to match this? I can't remember.

@nicolaskruchten
No. It was before applying 078c007
in respect to @alexcjohnson's #4810 (comment).
The PR description is modified above.

archmoj · 2020-05-04T19:08:57Z

Fixes#4806 and fixes#4808~~also now one could strat drawing over shapes no matter what the opacity of the below shape is~~.

Codepen after: https://codepen.io/MojtabaSamimi/pen/WNQdQZv

@plotly/plotly_js
@emmanuelle

…e editable shapes

alexcjohnson · 2020-05-04T19:22:38Z

 setupDragElement(gd, path, options, index, shapeLayer, editHelpers);
+ } else {
+ if(options.editable === true) {
+ path.style('pointer-events', 'stroke');


As long as this is scoped to options.editable === true, can't we still allow clicking on the fill when it's mostly opaque? >0.5 seems a fine cutoff to me. I feel like that's the behavior people will expect - most importantly when there's no stroke but even when there is as long as there's a strong fill.

Revised in 078c007.

alexcjohnson · 2020-05-04T21:00:02Z

+ }
+ }
+ ]
+ }, onfig: {


Suggested change
},onfig: {
},config: {

typo of the week

alexcjohnson

Fantastic! Just one little typo to fix and this should be ready! 💃

nicolaskruchten · 2020-05-05T15:14:14Z

@archmoj re:

now one could strat drawing over shapes no matter what the opacity of the below shape is.

do we need to change one of the schema attribute descriptions to match this? I can't remember.

archmoj · 2020-05-05T15:17:58Z

@archmoj re:
now one could strat drawing over shapes no matter what the opacity of the below shape is.
do we need to change one of the schema attribute descriptions to match this? I can't remember.

@nicolaskruchten
No. It was before applying 078c007
in respect to @alexcjohnson's #4810 (comment).
The PR description is modified above.

fix issue 4806 and 4808 - use and ensure stroke event only to activat…
3e96a40
…e editable shapes

archmoj added bug something broken status: reviewable regression this used to work labels May 4, 2020

archmoj added this to the v1.54.1 milestone May 4, 2020

alexcjohnson reviewed May 4, 2020
View reviewed changes

allow activation of editable shapes using opaque fill
078c007

alexcjohnson reviewed May 4, 2020
View reviewed changes

alexcjohnson approved these changes May 4, 2020
View reviewed changes

fixup config editable: true test
bb3f858

archmoj merged commit 9112759 into masterMay 4, 2020

archmoj deleted the fix4808-shape-pointer-events branch May 4, 2020 21:08

fix issue 4806 and 4808 - use and ensure stroke event only to activat…
3e96a40
…e editable shapes

archmoj added bug something broken status: reviewable regression this used to work labels May 4, 2020

archmoj added this to the v1.54.1 milestone May 4, 2020

alexcjohnson reviewed May 4, 2020
View reviewed changes

allow activation of editable shapes using opaque fill
078c007

alexcjohnson reviewed May 4, 2020
View reviewed changes

alexcjohnson approved these changes May 4, 2020
View reviewed changes

fixup config editable: true test
bb3f858

archmoj merged commit 9112759 into masterMay 4, 2020

archmoj deleted the fix4808-shape-pointer-events branch May 4, 2020 21:08

fix issue 4806 and 4808 - use and ensure stroke event only to activat…
3e96a40
…e editable shapes

archmoj added bug something broken status: reviewable regression this used to work labels May 4, 2020

archmoj added this to the v1.54.1 milestone May 4, 2020

alexcjohnson reviewed May 4, 2020
View reviewed changes

allow activation of editable shapes using opaque fill
078c007

alexcjohnson reviewed May 4, 2020
View reviewed changes

alexcjohnson approved these changes May 4, 2020
View reviewed changes

fixup config editable: true test
bb3f858

archmoj merged commit 9112759 into masterMay 4, 2020

archmoj deleted the fix4808-shape-pointer-events branch May 4, 2020 21:08

fix issue 4806 and 4808 - use and ensure stroke event only to activat…
3e96a40
…e editable shapes

archmoj added bug something broken status: reviewable regression this used to work labels May 4, 2020

archmoj added this to the v1.54.1 milestone May 4, 2020

alexcjohnson reviewed May 4, 2020
View reviewed changes

allow activation of editable shapes using opaque fill
078c007

alexcjohnson reviewed May 4, 2020
View reviewed changes

alexcjohnson approved these changes May 4, 2020
View reviewed changes

fixup config editable: true test
bb3f858

archmoj merged commit 9112759 into masterMay 4, 2020

archmoj deleted the fix4808-shape-pointer-events branch May 4, 2020 21:08

fix issue 4806 and 4808 - use and ensure stroke event only to activat…
3e96a40
…e editable shapes

archmoj added bug something broken status: reviewable regression this used to work labels May 4, 2020

archmoj added this to the v1.54.1 milestone May 4, 2020

alexcjohnson reviewed May 4, 2020
View reviewed changes

allow activation of editable shapes using opaque fill
078c007

alexcjohnson reviewed May 4, 2020
View reviewed changes

alexcjohnson approved these changes May 4, 2020
View reviewed changes

fixup config editable: true test
bb3f858

archmoj merged commit 9112759 into masterMay 4, 2020

archmoj deleted the fix4808-shape-pointer-events branch May 4, 2020 21:08

fix issue 4806 and 4808 - use and ensure stroke event only to activat…
3e96a40
…e editable shapes

archmoj added bug something broken status: reviewable regression this used to work labels May 4, 2020

archmoj added this to the v1.54.1 milestone May 4, 2020

alexcjohnson reviewed May 4, 2020
View reviewed changes

allow activation of editable shapes using opaque fill
078c007

alexcjohnson reviewed May 4, 2020
View reviewed changes

alexcjohnson approved these changes May 4, 2020
View reviewed changes

fixup config editable: true test
bb3f858

archmoj merged commit 9112759 into masterMay 4, 2020

archmoj deleted the fix4808-shape-pointer-events branch May 4, 2020 21:08

fix issue 4806 and 4808 - use and ensure stroke event only to activat…
3e96a40
…e editable shapes

archmoj added bug something broken status: reviewable regression this used to work labels May 4, 2020

archmoj added this to the v1.54.1 milestone May 4, 2020

alexcjohnson reviewed May 4, 2020
View reviewed changes

allow activation of editable shapes using opaque fill
078c007

alexcjohnson reviewed May 4, 2020
View reviewed changes

alexcjohnson approved these changes May 4, 2020
View reviewed changes

fixup config editable: true test
bb3f858

archmoj merged commit 9112759 into masterMay 4, 2020

archmoj deleted the fix4808-shape-pointer-events branch May 4, 2020 21:08

Uh oh!

Uh oh!

Conversation

archmoj commented May 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

nicolaskruchten commented May 5, 2020

Uh oh!

archmoj commented May 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

archmoj commented May 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

nicolaskruchten commented May 5, 2020

Uh oh!

archmoj commented May 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

archmoj commented May 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

nicolaskruchten commented May 5, 2020

Uh oh!

archmoj commented May 5, 2020

Uh oh!

Reviewers

archmoj commented May 4, 2020•
edited
Loading

archmoj commented May 4, 2020•
edited
Loading

archmoj commented May 4, 2020•
edited
Loading

archmoj commented May 4, 2020•
edited
Loading