Skip to content

Fix rangebreaks on heatmap with 2d z array - #4821

Merged
archmoj merged 6 commits into
masterfrom
rangebreaks-heatmap-2d-z-array
May 11, 2020
Merged

Fix rangebreaks on heatmap with 2d z array#4821
archmoj merged 6 commits into
masterfrom
rangebreaks-heatmap-2d-z-array

Conversation

@archmoj

@archmojarchmoj commented May 7, 2020

Copy link
Copy Markdown
Contributor

Fixes: #4818 | demo: before vs after.

@plotly/plotly_js

@archmojarchmoj added bug something broken status: reviewable labels May 7, 2020
@archmojarchmoj added this to the v1.54.2 milestone May 7, 2020
@archmoj
archmoj requested a review from alexcjohnsonMay 7, 2020 22:08
alexcjohnson
alexcjohnson reviewed May 8, 2020
View reviewed changes
Comment threadtest/image/mocks/axes_breaks-heatmap1d.json Outdated
"2020-01-02 17:40",
"2020-01-02 17:50",
"2020-01-02 18:00",
"2020-01-02 18:10"

@alexcjohnsonalexcjohnsonMay 8, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests include some removed data, which is good - but can we also include some data on the other side of the break, ie the next morning?

@archmojarchmojMay 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Done in e2cf395.

@alexcjohnson

alexcjohnson commented May 8, 2020

Copy link
Copy Markdown
Collaborator

Does this fix also support histogram2d with rangebreaks?

@archmoj

archmoj commented May 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Does this fix also support histogram2d with rangebreaks?

Not sure about that one. Is there any problem you noticed with histogram2d and rangebreaks?

@alexcjohnson

alexcjohnson commented May 8, 2020

Copy link
Copy Markdown
Collaborator

I haven't tried histogram2d with rangebreaks but I know it shares a lot of code with heatmap so seems natural to address them together.

@archmoj
add tests for coutour with rangebreaks & 1d and 2d z array
a7676bd
- remove duplicate points from heatmap mocks
@archmoj

archmoj commented May 11, 2020

Copy link
Copy Markdown
ContributorAuthor

I added tests for contour in a7676bd.
The histogram2d case is tracked in #4825 amd it would be addressed in a separate PR.

alexcjohnson
alexcjohnson approved these changes May 11, 2020
View reviewed changes

@alexcjohnsonalexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for testing this out with contour as well! Agreed we can push histogram2d to another PR, I just wanted to ensure we didn't forget about it. 💃

@archmoj
archmoj merged commit 5d35b78 into masterMay 11, 2020
@archmoj
archmoj deleted the rangebreaks-heatmap-2d-z-array branch May 11, 2020 18:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnsonalexcjohnsonalexcjohnson approved these changes

Assignees

No one assigned

Labels

bugsomething broken

Projects

None yet

Milestone

v1.54.2

Development

Successfully merging this pull request may close these issues.

plot & hover problems of heatmap (case of 2d-z array) with rangebreaks

2 participants

@archmoj@alexcjohnson