Skip to content

Fix tosvg in IE11 (and possibly other browsers)#489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 1 commit into from
Apr 28, 2016
Merged

Fix tosvg in IE11 (and possibly other browsers) #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/snapshot/tosvg.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -107,7 +107,7 @@ module.exports = function toSVG(gd, format) {

// remove draglayer for Adobe Illustrator compatibility
if(fullLayout._draggers) {
fullLayout._draggers.node().remove();
fullLayout._draggers.remove();

@mdtuszmdtuszApr 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Didn't know that was a d3 method. Makes sense.

@etpinardetpinardApr 28, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChildNode.remove is a thing though: https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove

but not in IE.

@etpinardetpinardApr 28, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

man, we really got to get a Windows dev to wrap up #431 for us.

}

// in case the svg element had an explicit background color, remove this
Expand Down