Skip to content

Fix hover on mobile and tablet devices for gl3d subplots - #5239

Merged
archmoj merged 5 commits into
plotly:masterfrom
jdpaterson:master
Nov 2, 2020
Merged

Fix hover on mobile and tablet devices for gl3d subplots#5239
archmoj merged 5 commits into
plotly:masterfrom
jdpaterson:master

Conversation

@jdpaterson

Copy link
Copy Markdown
Contributor

Update gl-plot3d version to fix#4550 .
Related to gl-vis/gl-plot3d#31

@archmoj

Copy link
Copy Markdown
Contributor

Thanks very much for the PR!
There is only one test failing now.

it('@gl should not scroll document while panning',function(done){
varmock={
data: [
{type: 'scatter3d'}
],
layout: {
width: 500,
height: 500,
scene: {camera: {eye: {x: 0.1,y: 0.1,z: 1}}}
}
};
varsceneTarget;
varrelayoutCallback=jasmine.createSpy('relayoutCallback');
functionassertEvent(e){
expect(e.defaultPrevented).toEqual(true);
relayoutCallback();
}
gd.addEventListener('touchend',assertEvent);
gd.addEventListener('touchstart',assertEvent);
gd.addEventListener('touchmove',assertEvent);
gd.addEventListener('wheel',assertEvent);
Plotly.plot(gd,mock)
.then(function(){
sceneTarget=gd.querySelector('.svg-container .gl-container #scene');
returndrag({touch: true,node: sceneTarget,pos0: [100,100],posN: [0,0],noCover: true});
})
.then(function(){
returndrag({node: sceneTarget,pos0: [100,100],posN: [0,0],noCover: true});
})
.then(function(){
returnscroll(sceneTarget);
})
.then(function(){
expect(relayoutCallback).toHaveBeenCalledTimes(3);
})
.catch(failTest)
.then(done);
});

@jdpaterson could you please investigate why?

@archmojarchmoj changed the title update gl-plot3d versionFix hover on mobile and tablet devices for gl3d subplotsOct 29, 2020
@archmojarchmoj added status: in progress bug something broken regression this used to work labels Oct 29, 2020
Comment threadtest/jasmine/tests/gl3d_plot_interact_test.js Outdated
use non-blocking assert syntax
@jdpaterson

Copy link
Copy Markdown
ContributorAuthor

@archmoj the test-bundle timed out during the mapbox plot tests. Is this something I should be concerned about here?

@archmoj

Copy link
Copy Markdown
Contributor

@archmoj the test-bundle timed out during the mapbox plot tests. Is this something I should be concerned about here?

@jdpaterson No. I'll re-run the container tomorrow.
Also I'll spend more time testing.
Thanks again for the fantastic work.

Comment threadpackage.json Outdated
@archmoj

Copy link
Copy Markdown
Contributor

Nicely done! 🥇 🎖️ @jdpaterson
💃

@archmoj
archmoj merged commit 0d79ea9 into plotly:masterNov 2, 2020
@archmojarchmoj added this to the v1.58.0 milestone Dec 2, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugsomething brokenregressionthis used to work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gl3d hover not working on mobile and tablet since v1.34.0

2 participants

@jdpaterson@archmoj