Uh oh!
There was an error while loading. Please reload this page.
Adjust imaginary tickvals default to fix react - #5992
Merged
Conversation
| var imagTickvalsDflt = | ||
| realTickvals.slice().reverse().map(function(x) { return -x; }) | ||
| .concat([0]) | ||
| .concat(realTickvals); |
Collaborator
There was a problem hiding this comment.
I imagine the problem with this is we get a new array each time, so Plotly.react thinks this has changed and needs replotting? I do think as a default this behavior makes sense, can we fix it with a simple memoizer? Something like:
functionmemoize(fn,keyFn){varcache={};returnfunction(val){varnewKey=keyFn ? keyFn(val) : val;if(newKeyincache){returncache[newKey];}out=fn(val);cache[newKey]=out;returnout;}}varmakeImagDflt=memoizeOne(function(realTickvals){returnrealTickvals.slice().reverse().map(function(x){return-x;}).concat([0]).concat(realTickvals);},String);vara=makeImagDflt([2,4,5])varb=makeImagDflt([2,4,5])a===b// truevarc=makeImagDflt([1,2,3])vard=makeImagDflt([2,4,5])d===b// trueA memoizer might be useful in other contexts too... we use them quite a lot in Dash anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The magical default for imaginary
tickvalsadded in #5956 (comment) broke the react ("noCi"plotl_api_react_test).@plotly/plotly_js