Uh oh!
There was an error while loading. Please reload this page.
DRY up color attributes - #609
Conversation
| 'use strict'; | ||
| module.exports = function makeColorScaleAttributes(context) { |
925aa58 to
eb4d42aCompareOutstanding reviewables:
|
7595849 to
ab843f5Compareab843f5 to
99abf13Compareetpinard
commented
Jun 7, 2016
I would prefer leaving
Your call. I'm ok with leaving the surface variation as is or make |
monfera
commented
Jun 7, 2016
@etpinard thanks! As a clarification: while |
etpinard
commented
Jun 7, 2016
Nice catch!
Exactly. Let's get rid of those deprecated |
monfera
commented
Jun 7, 2016
@etpinard can I remove them in general? I.e. even from |
etpinard
commented
Jun 7, 2016
monfera
commented
Jun 7, 2016
OK, Limbo Stage 2 for these props 😼 |
| ' `cmin` and `cmax` if set.' | ||
| ].join('') | ||
| }, | ||
| colorscale: extendDeep({}, colorScaleAttributes.colorscale, { |
There was a problem hiding this comment.
extendFlat would suffice here, correct?
There was a problem hiding this comment.
Yes in general I might have been overly defensive with extendDeep. Should I convert all these extendDeep calls to extendFlat? It would work unless someone mutated the attribute object by accident.
This is a PR that is a prequel to #581 (covered with a PoC already) with the purpose of centralizing shared color attribute specifications. This is a non-functional change that consolidates attribute lines but should leave operations identical, beyond the odd case where the new version sometimes has more descriptive descriptions (the former code sometimes used
markereven when the reference was included inmarker.line). The new vertex/line color spec solution for #581 can thus use the new color spec attributes in bulk, without having to add them one by one.