property x0shift, x1shift, y0shift, y1shift for adjusting the shape coordinates by my-tien · Pull Request #7005 · plotly/plotly.js

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien · 2024-05-27T10:16:02Z

This property adjusts the shape coordinates if xref/yref references a (multi-)category axis.

A shape at position x0/x1 = "A"

with x0shift = 0.5

Disclaimer

I am required to add that…

the software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. in no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

Only for shapes with reference to (multi-)category axis

…mock

If the passed shift param is undefined, use shift 0 instead.

archmoj · 2024-05-31T14:19:12Z

+ 'the reference unit.'
+ ].join(' ')
+ },
+


We should also add these to newselection and test it.

archmoj · 2024-05-31T14:30:01Z

+ "y1": 0.5,
+ "xshift": -0.25,
+ "yref": "paper"
+ }


Is this also working for a path?

No, this should only do something when using x0, x1, y0, y1

archmoj · 2024-05-31T14:33:36Z

Interesting PR for shapes and selections.
But I started wondering perhaps we should add a categoryshift option to Cartesian axes instead?

archmoj · 2024-05-31T15:05:15Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

archmoj · 2024-05-31T15:11:12Z

Let's ask @alexcjohnson to review 🔎

my-tien · 2024-06-03T14:19:57Z

I am wondering if adding a categoryselectionstart, categoryselectionend, categoryshapestart and categoryshapeend to cartesian axes is a better option?

Here is a PR with this suggestion for shapes only: #7010 (I actually only included selection in this PR, because it reuses shape properties.)

archmoj · 2024-06-04T14:52:51Z

Considering #7010 (comment) discussion,
two attributes are needed for start and the end i.e. instead of xshift which is already implemented we need x0shift and x1shift.

archmoj · 2024-07-11T01:40:31Z

Thanks for the simplification.
Please update the PR title and description.
Also zzz_shape_shift_vertical image test is failing now.

archmoj · 2024-07-11T01:42:15Z

@stephprobst Do you have a use case for date axes?
If so it could be possible to add these options for other axis types.

stephprobst · 2024-07-11T05:22:13Z

@stephprobst Do you have a use case for date axes? If so it could be possible to add these options for other axis types.

@archmoj No, I don't think this is relevant for other axes. The rationale for this property is to allow exact positioning of a shape based on the axis value. For categorical axes this is needed, because it allows the combination of categorical and numerical values (e.g. country "Canada" plus a shift of 0.5 to position the shape at the end of the categories interval on the axis). On numerical or date axes this isn't really needed, since the user can directly select the precise numerical or date value (e.g. "2023-12-31" to position a shape at the end of year 2023).

My proposal would be to skip the implementation for date and numeric axes.

- removed selection - reversed axis

archmoj · 2024-07-11T16:23:04Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

archmoj · 2024-07-11T16:26:53Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock.
Thank you!

- Add texttemplate with slope and xcenter to mock

my-tien · 2024-07-15T21:36:20Z

Please also test texttemplate on your mocks to show the slopes similar to those in the text_on_shapes_texttemplate mock. Thank you!

I noticed that I didn't account for the shift for the texttemplate. Fixed that and added a test shape with slope and xcenter.

my-tien · 2024-07-15T21:36:34Z

When shape.editable is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Fixed

archmoj

Thanks @my-tien for the PR 🥇
💃

my-tien added 3 commits May 27, 2024 12:14

property shape.x_shift/y_shift for adjusting the shape coordinates
aa0cd7a
Only for shapes with reference to (multi-)category axis

Add draftlog for PR 7005
44d1858

Add x_shift/y_shift for selections as well, add selection example to …
7abea61
…mock

my-tien changed the title ~~property shape.x_shift/y_shift for adjusting the shape coordinates~~property x_shift/y_shift for adjusting the shape/selection coordinatesMay 27, 2024

my-tien added 2 commits May 27, 2024 13:10

baseline images zzz_shape_shift_horizontal and zzz_shape_shift_vertical
a617017

Update shapes_test after adding shift param to getDataToPixel
c2f7f27
If the passed shift param is undefined, use shift 0 instead.

archmoj added feature something new community community contribution status: reviewable labels May 30, 2024

archmoj reviewed May 30, 2024
View reviewed changes

Comment threadsrc/components/selections/attributes.js Outdated

archmoj reviewed May 30, 2024
View reviewed changes

Comment threadsrc/components/selections/attributes.js Outdated

archmoj reviewed May 30, 2024
View reviewed changes

Comment threadsrc/components/shapes/attributes.js

archmoj mentioned this pull request May 30, 2024
Add ticklabelstandoff and ticklabelshift to cartesian axes #7006
Merged

Rename x_shift/y_shift → xshift/yshift
fdcaa0c

archmoj reviewed May 31, 2024
View reviewed changes

Comment threadsrc/components/selections/defaults.js Outdated

archmoj reviewed May 31, 2024
View reviewed changes

Comment threadsrc/components/shapes/defaults.js Outdated

archmoj reviewed May 31, 2024
View reviewed changes

Comment threadsrc/components/shapes/helpers.js Outdated

archmoj reviewed May 31, 2024
View reviewed changes

Comment threadtest/image/mocks/zzz_shape_shift_horizontal.json

archmoj reviewed May 31, 2024
View reviewed changes

archmoj requested review from alexcjohnson and emilykl May 31, 2024 15:11

alexcjohnson reviewed Jun 1, 2024
View reviewed changes

Comment threadtest/image/mocks/zzz_shape_shift_horizontal.json Outdated

my-tien mentioned this pull request Jun 3, 2024
categoryshapeshiftstart and categoryshapeshiftend properties for category axes #7010
Closed

archmoj reviewed Jun 4, 2024
View reviewed changes

Comment threadsrc/components/selections/attributes.js Outdated

archmoj reviewed Jul 11, 2024
View reviewed changes

Comment threadsrc/components/shapes/helpers.js Outdated

my-tien changed the title ~~property x0shift, x1shift, y0shift, y1shift for adjusting the shape/selection coordinates~~property x0shift, x1shift, y0shift, y1shift for adjusting the shape coordinatesJul 11, 2024

my-tien added 2 commits July 11, 2024 12:11

Fix getPixelShift for reversed axes, add reversed axis to mock
78a7e5e

Update baseline image of zzz_shape_shift_vertical
18e7c84
- removed selection - reversed axis

archmoj reviewed Jul 11, 2024
View reviewed changes

Comment threadsrc/components/shapes/calc_autorange.js

archmoj reviewed Jul 11, 2024
View reviewed changes

Comment threadsrc/components/shapes/helpers.js

my-tien added 2 commits July 15, 2024 16:26

Account for shift when dragging a shape
5509ee6

Support shape shift in texttemplate as well
6f8e5a6
- Add texttemplate with slope and xcenter to mock

Update baseline image after updated mock for texttemplate shape
7de45c3

archmoj reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/components/shapes/attributes.js Outdated

LiamConnors reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/components/shapes/attributes.js Outdated

Refine description for x0shift/x1shift/y0shift/y1shift
9ac970a

archmoj removed the status: has TODOs label Jul 16, 2024

archmoj approved these changes Jul 16, 2024
View reviewed changes

archmoj merged commit e2653aa into plotly:masterJul 16, 2024

FlorentinTh mentioned this pull request Aug 9, 2024
[Snyk] Upgrade plotly.js-cartesian-dist-min from 2.12.1 to 2.34.0 FlorentinTh/LE2ML-GUI#773
Open

guaiya0507 mentioned this pull request Aug 9, 2024
[Snyk] Upgrade plotly.js-dist-min from 2.33.0 to 2.34.0 guaiya0507/mytool#3
Open

This was referenced Sep 29, 2024
[Snyk] Upgrade plotly.js-cartesian-dist-min from 2.12.1 to 2.35.0 FlorentinTh/LE2ML-GUI#778
Open
[Snyk] Upgrade plotly.js-cartesian-dist-min from 2.12.1 to 2.35.1 FlorentinTh/LE2ML-GUI#781
Open

extrafu mentioned this pull request Oct 2, 2024
[Snyk] Upgrade plotly.js-dist-min from 2.32.0 to 2.35.2 inverse-inc/packetfence#8336
Merged

FlorentinTh mentioned this pull request Oct 2, 2024
[Snyk] Upgrade plotly.js-cartesian-dist-min from 2.12.1 to 2.35.2 FlorentinTh/LE2ML-GUI#782
Open

FlorentinTh mentioned this pull request Oct 22, 2024
[Snyk] Upgrade plotly.js-cartesian-dist-min from 2.12.1 to 2.35.2 FlorentinTh/LE2ML-GUI#785
Open

archmoj mentioned this pull request Jul 14, 2025
Editable shapes seem to be broken going from 2.33.0 to 2.34.0 and beyond #7465
Closed