Skip to content

load maki icon - #7068

Merged
archmoj merged 5 commits into
plotly:add-maplibre-optionfrom
birkskyum:load-maki-icons
Jul 26, 2024
Merged

load maki icon#7068
archmoj merged 5 commits into
plotly:add-maplibre-optionfrom
birkskyum:load-maki-icons

Conversation

@birkskyum

@birkskyumbirkskyum commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

@archmoj, links to icons/sprites are usually inside the style.json itself, but for compatibility if a maki icon (gh repo) is detected as missing, this PR will make sure it's downloaded and rendered.

Screenshot 2024-07-26 at 19 02 23

@birkskyumbirkskyum mentioned this pull request Jul 26, 2024
@archmojarchmoj added bug something broken community community contribution status: reviewable labels Jul 26, 2024
@archmoj

Copy link
Copy Markdown
Contributor

@birkskyum

Copy link
Copy Markdown
ContributorAuthor

You're very welcome. They are update now.

@archmoj

Copy link
Copy Markdown
Contributor

When comparing the diffs here https://github.com/plotly/plotly.js/pull/7015/files#diff-f0fbe3130eb2e4f0e1c8faf5ba166a839a3dfdce358c2e60d6f9c8ee5ccf475b
I see a lighter color being used on the mapbox baselines.
But the symbols here show in black!
Does marker.color work?

@birkskyum

Copy link
Copy Markdown
ContributorAuthor

@archmoj setting marker.color: '#ffff00', (yellow) appear to change the color of the line between the icons for both mapbox/maplibre.

@birkskyum

Copy link
Copy Markdown
ContributorAuthor

This is an area where both mapbox/maplibre are too strict. We're planning to add proper SVG support, which would make things easier to style and improve in other areas too - maplibre/maplibre#175.

@archmoj

Copy link
Copy Markdown
Contributor

Please add 'map_angles' to isOtherFlaky list in test/image/compare_pixels_test.js.
Thank you!

@archmoj

Copy link
Copy Markdown
Contributor

💃
Thanks very much.
FYI I'll fix the b64 image test on my PR.

@archmoj
archmoj merged commit 096b347 into plotly:add-maplibre-optionJul 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugsomething brokencommunitycommunity contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum@archmoj